Tuan/fix ante #166
Closed
Tuan/fix ante #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update proto-builder for sdk47
Ducnt/proto
This reverts commit 8c28b00.
bump sdk 47
change to ibc-app PFM
* Add test for Makefile and add some ignores. * Disable goconst lint * Disable revive lint
* refactor: minor code improvements * refactor: namming and remove unused code --------- Co-authored-by: Duong Minh Ngoc <[email protected]>
* Add unit test for delete proposal. * Add testcase delete not exists host zone config for TestDeleteHostZoneProposal.
* Add error handling and some refactor. * Fix lints * Fix logic delete host zone config * Change proposal keys.
* test: add host zone proposal interchain test * test: add workflow config --------- Co-authored-by: Tien Nguyen <[email protected]>
Co-authored-by: Duong Minh Ngoc <[email protected]>
* refactor: optimize kvstore calls * refactor: optimize epoch info kvstore calls * refactor: optimize kv store calls * add test for epoch info
* refactor: move custom interchaintest logic from notional repo * refactor: refactor interchain test --------- Co-authored-by: Tien Nguyen <[email protected]>
* Handle error on interchaintest. * Fix query not found host zone config. * Refactor import by goimports.
Co-authored-by: Duong Minh Ngoc <[email protected]>
* Remove unused code. * Refactor code in app and cmd * Correct proto name and doc.
* split package forward test * fix pointer query smart msg response
* Upgrade ibc packet forwarder. * Fix some errors. * Fix relayer images version * Fix test invalid balance between int64 and math.Int * Some refactors.
* Send package in batch * test: add query osmosis twap test * test: add makefile and github worklow * handle error while sending in batch * update query osmosis twap test * fix makefile * test: temp disable query osmosis twap assertion
…145) * Remove unused ante package. * Add benchmarking setup for testnet. * Fix lint.
…ew host zone. (#146) * Avoid add duplicate host zone proposal and remove old data when set new host zone. * Remove check host zone config by osmosis denom * Fix lint * Change gas for exec tx proposal
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| authtypes.ProtoBaseAccount, | ||
| maccPerms, | ||
| sdk.Bech32PrefixAccAddr, |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
|
This one is opened to wrong branch, it should go to here: https://github.com/osmosis-labs/fee-abstraction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should make the feeRequired and FeeCoins more clear and descriptive.
nonZeroCoinFeesReqis supposed to be a native fees(in case the min-gas-prices is set as so). As a result,CalculateNativeFromIBCCoinsshouldn't accept it as theibcCoinsparameters