Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only need ibc_denom to DeleteHostZoneProposal #121

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Only need ibc_denom to DeleteHostZoneProposal #121

merged 4 commits into from
Mar 27, 2023

Conversation

anhductn2001
Copy link
Contributor

Close #112

@anhductn2001 anhductn2001 requested a review from GNaD13 March 23, 2023 12:57
@anhductn2001
Copy link
Contributor Author

Can you review it @GNaD13 ?

@GNaD13
Copy link
Contributor

GNaD13 commented Mar 26, 2023

@anhductn2001 Can you recheck with the test and lint?

@anhductn2001
Copy link
Contributor Author

I think it ready now @GNaD13

@GNaD13 GNaD13 merged commit fe3e008 into main Mar 27, 2023
@GNaD13
Copy link
Contributor

GNaD13 commented Mar 27, 2023

Thank you @anhductn2001

@anhductn2001 anhductn2001 deleted the ducnt/112 branch March 27, 2023 09:42
tuantran1702 pushed a commit that referenced this pull request Mar 4, 2024
* Add unit test for delete proposal.

* Add testcase delete not exists host zone config for TestDeleteHostZoneProposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete hostzone proposal
2 participants