-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UV search bugs #199
Comments
This commit will constrain the IIIF search to only search the file sets of a work. This way applications that use all_text_tsimv for both the file sets and work (to support snippets) will not have the work's text included in the search which would double the results. Ref: - notch8/palni_palci_knapsack#199
This commit will update IIIF Print gem's revision to include a fix for duplicate search results coming through the UV. Ref: - notch8/iiif_print#379 - notch8/palni_palci_knapsack#199
This commit will update the Hyku submodule to bring in fixes from IIIF Print. Ref: - #199
QA RESULTS: ❌ Needs Reworktested on STAGING The count bug has been fixed 🎉 but there are still issues for pals. I've updated the ticket to better describe the other issues found. cc @kirkkwang In the latest iteration/retest, the search term isn't being carried over into the work's show page (however this is working in hyku-demo staging). When i hover over the link or thumbnail I am not seeing the search query in the url. This seems to be a new issue from the first time I went sleuthing. PALS STAGINGHYKU DEMOnotice the highlight=true and parent_query=lamp in the bottom url/hover |
@ShanaLMoore I see you're clicking on the thumbnail, which is a different behavior than clicking on the title. Should they be the same? Hmmm, there might be an override in pals specifically that isn't giving us the default Hyku behavior, I'll look into it. |
Yes, they should behave the same. Both the thumbnail and the titles should link you to the record show page with the params to highlight the word. You should be able to verify this behavior in Hyku. cc @kirkkwang |
This commit will remove an override so we can use Hyku's default behavior for the thumbnail list in which we can carry over the search term to the UV when clicking on a thumbnail. Ref: - #199
Summary
UV search doesn't appear to be working properly && Hyku seems to be performing better than Pals.
Issues discovered so far:
Acceptance Criteria
If no matches are found, a pop up box should appear stating so when searching the UV.
If matches are found and UV feature flag is ON...
Screenshots or Video
Testing Instructions
Notes
related?
The text was updated successfully, but these errors were encountered: