Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV search bugs #199

Open
6 tasks
ShanaLMoore opened this issue Jan 22, 2025 · 3 comments
Open
6 tasks

UV search bugs #199

ShanaLMoore opened this issue Jan 22, 2025 · 3 comments
Assignees

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 22, 2025

Summary

UV search doesn't appear to be working properly && Hyku seems to be performing better than Pals.

Issues discovered so far:

  • count is incorrect (also present in Hyku)
  • matched words are not highlighting in the UV
  • matched words are not highlighting when searched from catalog controller

Acceptance Criteria

If no matches are found, a pop up box should appear stating so when searching the UV.

If matches are found and UV feature flag is ON...

  • Go to any work with a UV and OCR. Searching for a word should highlight the matched words.
    • OCR work means it's gone through word processing. You'll know if a work has been through OCR when you click on a one (ie: a wordk that has an image with a word), and scroll down to the file in the items section. Click on the file, then scroll down again to the items section. Click Actions > download as txt and it'll download a file with words. These are the words you should be able to search and get matches.
  • Searching for a word in the UV should display the correct count
    • if there's more than one match, clicking next result should take you the next matched words (it'll be in a different location and highligted)
  • Searching for a word from the catalog search page should result in matches with highlighted snippets
    • click into this work, the first matched word should automatically be found and highlighted in the UV
    • click into this work, the first matched word should automatically be found and highlighted in the PDF.js if applicable (PDF files and UV feature turned off).

Screenshots or Video

Image

Testing Instructions

  1. Create or find a work that will generate OCR
  2. From the catalog search, search for one of the OCR words
  3. That work should appear in the results with highlighted snippets. When you click into it it should redirect you to the work's show page and automatically search + find the word match in the UV. That word(s) should be highlighted and display a correct count of matches.
  4. searching child works with a hit should return a match (it currently says there are no matches)

Notes

related?

@ShanaLMoore ShanaLMoore mentioned this issue Jan 22, 2025
6 tasks
@ShanaLMoore ShanaLMoore self-assigned this Jan 23, 2025
@ShanaLMoore ShanaLMoore moved this to In Development in PalsKnapsack Jan 23, 2025
@ShanaLMoore ShanaLMoore removed their assignment Jan 24, 2025
@kirkkwang kirkkwang self-assigned this Jan 27, 2025
kirkkwang added a commit to notch8/iiif_print that referenced this issue Jan 27, 2025
This commit will constrain the IIIF search to only search the file sets
of a work.  This way applications that use all_text_tsimv for both the
file sets and work (to support snippets) will not have the work's text
included in the search which would double the results.

Ref:
- notch8/palni_palci_knapsack#199
kirkkwang added a commit to samvera/hyku that referenced this issue Jan 27, 2025
This commit will update IIIF Print gem's revision to include a fix for
duplicate search results coming through the UV.

Ref:
- notch8/iiif_print#379
- notch8/palni_palci_knapsack#199
kirkkwang added a commit that referenced this issue Jan 27, 2025
This commit will update the Hyku submodule to bring in fixes from IIIF
Print.

Ref:
- #199
@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Jan 28, 2025
@ShanaLMoore ShanaLMoore moved this from In Development to Ready for Development in PalsKnapsack Jan 28, 2025
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jan 28, 2025

QA RESULTS: ❌ Needs Rework

tested on STAGING

The count bug has been fixed 🎉 but there are still issues for pals.

I've updated the ticket to better describe the other issues found. cc @kirkkwang

In the latest iteration/retest, the search term isn't being carried over into the work's show page (however this is working in hyku-demo staging).

When i hover over the link or thumbnail I am not seeing the search query in the url. This seems to be a new issue from the first time I went sleuthing.

PALS STAGING

Image

Image

HYKU DEMO

notice the highlight=true and parent_query=lamp in the bottom url/hover

Image

Image

@kirkkwang
Copy link
Contributor

kirkkwang commented Jan 29, 2025

@ShanaLMoore I see you're clicking on the thumbnail, which is a different behavior than clicking on the title. Should they be the same?

Hmmm, there might be an override in pals specifically that isn't giving us the default Hyku behavior, I'll look into it.

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Jan 29, 2025

Yes, they should behave the same. Both the thumbnail and the titles should link you to the record show page with the params to highlight the word. You should be able to verify this behavior in Hyku. cc @kirkkwang

kirkkwang added a commit that referenced this issue Jan 29, 2025
This commit will remove an override so we can use Hyku's default
behavior for the thumbnail list in which we can carry over the search
term to the UV when clicking on a thumbnail.

Ref:
- #199
@ShanaLMoore ShanaLMoore removed the needs rework issue needs additional work label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Development
Development

No branches or pull requests

2 participants