Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pals update bugs #164

Closed
6 tasks done
jillpe opened this issue Nov 18, 2024 · 1 comment
Closed
6 tasks done

Pals update bugs #164

jillpe opened this issue Nov 18, 2024 · 1 comment
Assignees

Comments

@jillpe
Copy link

jillpe commented Nov 18, 2024

With the update of the submodule (bringing in Hyrax, Bulkrax, and IiifPrint updates) I'm documenting the bugs I which that may or may not be in tickets elsewhere.

These will either be resolved by this ticket, or moved to a new ticket if one doesn't already exist.

  • Can not edit due to location (based_near) errors after initial save.
  • Collection banner and logo branding do not save
  • Location on collection show page (public and dashboard) shows location url instead of label
  • OER show page doesn't show location
  • Universal viewer text search is broken (NoMethodError (undefined method '-' for nil:NilClass) in iiif_print (acef382ce710) app/models/iiif_print/iiif_search_response_decorator.rb:25:in 'remove_invalid_hit'
  • Snippets show full text when there is no search
@laritakr laritakr self-assigned this Nov 18, 2024
@laritakr laritakr changed the title Pals update bugs identified Pals update bugs Nov 19, 2024
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jan 21, 2025

QA RESULTS: ✅ PASS

tested on STAGING

  • Can not edit due to location (based_near) errors after initial save.

Image

Image

  • Location on collection show page (public and dashboard) shows location url instead of label

Dashboard

Image

Public

Image

  • OER show page doesn't show location

Image

⚠ I'll consider this a pass and create a separate issue for the bug I found. Searching for a term doesn't produce the following error, however it there's a match it should be highlighted and it's not. Also the count is wrong. cc @laritakr - #199

  • Universal viewer text search is broken (NoMethodError (undefined method '-' for nil:NilClass) in iiif_print (acef382ce710) app/models/iiif_print/iiif_search_response_decorator.rb:25:in 'remove_invalid_hit'

Image

  • Snippets show full text when there is no search

empty search

Image

Searched for "cat"

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants