Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Dropdown #156

Open
9 tasks
jillpe opened this issue Oct 9, 2024 · 4 comments
Open
9 tasks

Search Dropdown #156

jillpe opened this issue Oct 9, 2024 · 4 comments
Assignees
@sjproctor
Labels
High Priority

Comments

@jillpe
Copy link

jillpe commented Oct 9, 2024 •
edited by sjproctor
Loading

Summary

The dropdown to search 'All of HykuCommons', 'My works', 'My colllections' is not dropping down in the correct spot. See screenshot below.

Knapsack

Image

HykuCommons

Image

Acceptance Criteria

  • The dropdown to search 'All of HykuCommons', 'My works', 'My collections' drops down in same spot as HykuCommons

Testing Instructions

  • Staging
  • Access application, log in as an administrator, see landing page
  • Click All dropdown menu on the search form while on the Default home theme
    • Ensure dropdown menu is on the right side of the screen
    • Ensure dropdown menu has pleasant styling (links are not underlined)
  • Click All dropdown menu on the search form while on the Cultural Repository theme
    • Ensure dropdown menu is on the right side of the screen
    • Ensure dropdown menu has pleasant styling (links are not underlined)
  • Click All dropdown menu on the search form while on the Institutional Repository theme
    • Ensure dropdown menu is on the right side of the screen
    • Ensure dropdown menu has pleasant styling (links are not underlined)
  • Click All dropdown menu on the search form while on the Neutral Repository theme
    • Ensure dropdown menu is on the right side of the screen
    • Ensure dropdown menu has pleasant styling (links are not underlined)
@jillpe jillpe converted this from a draft issue Oct 9, 2024
@laritakr laritakr mentioned this issue Dec 2, 2024
Open
19 tasks
@sjproctor sjproctor self-assigned this Jan 13, 2025
@sjproctor sjproctor moved this from Ready for Development to In Development in PalsKnapsack Jan 13, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Jan 14, 2025
@sjproctor
🧹 Updates to search form overrides
497f931 
This commit:
- updates the search form override view files for the cultural and
institutional repositories to align with existing code in Hyrax which
fixes styling issues in the dropdown menus
- updates the Hyku dependencies to the latest versions of Hyrax gems

Ref:
- notch8/palni_palci_knapsack#156
@sjproctor sjproctor mentioned this issue Jan 14, 2025
Merged
@sjproctor
Copy link
Contributor

Dev Notes 1/13/2025

  • Must be on a tenant and logged in as an admin to see the dropdown menu
  • All of Hyku dropdown menus in all themes are working properly
  • PALS has an override from Hyrax to add a button for Advanced in app/views/catalog/_search_form.html.erb for the default theme
    • Hyku pulls from Hyrax, so this file doesn't exist in Hyku
    • Action: styling changes need to be made to this file in PALS
  • Hyku has a text-decoration:none applied to all a tags while PALS has a default text-decoration:underline
  • Hyrax (Nurax-PG) has a better HTML structure for the drop down menu (div with dropdown menu class, links with dropdown item class)
  • There are overrides in Hyku that have a less desirable tag structure (ul, li, nested links)
  • Action: updating the Hyku tags to match Hyrax tag structure

sjproctor added a commit to samvera/hyku that referenced this issue Jan 14, 2025
@sjproctor
💄 Updated version number on the override files
0f29ec6 
Ref:
- notch8/palni_palci_knapsack#156
sjproctor added a commit that referenced this issue Jan 14, 2025
@sjproctor
🐛 Search Dropdown Menu Styling
d7e5815 
This commit:
- updates dropdown menu styling in the `_search_form.html.erb` override
file to match the structure and style of dropdown menu in Hyrax which
fixes reported styling errors
- updates the submodule that contains similar fixes to the dropdown menu
overrides for the Cultural and Institutional Repository themes

Ref:
- #156
@sjproctor sjproctor mentioned this issue Jan 14, 2025
Merged
@sjproctor sjproctor moved this from In Development to Deploy to Staging in PalsKnapsack Jan 15, 2025
@laritakr
Copy link
Contributor

QA in progress

@laritakr
Copy link
Contributor

QA Results:

Default Home: ✅ pass

Image

Neutral Repository: ✅ pass

Image

Cultural Repository: ✅ pass

Image

Institutional Repository: ✅ pass

Image

Catalog search (not listed explicitly on original ticket but also had the same problem: ✅ pass

Image

@laritakr laritakr moved this from Deploy to Staging to Client QA in PalsKnapsack Jan 16, 2025
@laritakr
Copy link
Contributor

I have noticed while doing QA above that there are inconsistencies in the custom colors behavior for these buttons. I will address these with the home page themes ticket #142

@ndroark ndroark moved this from Client QA to Deploy to Production in PalsKnapsack Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjproctor sjproctor

Labels
High Priority
Projects
PalsKnapsack
Status: Deploy to Production
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laritakr @sjproctor @jillpe