-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Page Themes #142
Labels
Comments
github-project-automation
bot
moved this from In Development
to Ready for Development
in PalsKnapsack
Jan 21, 2025
Merged
QA Results: Rework NeededRework NeededRework Suggested (Not strictly outlined in acceptance criteria, but may apply to this ticket)All themes [mobile view]: footer text is scrunched and does not adjust to a column format like in HykuCommonsProcess
Default Theme
Cultural Theme
Institutional Theme
Neutral Theme
|
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit fixes the mobile layout of the Neutral Theme by adding a media query to disable the flex property while in mobile view. Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit refactors the footer in all four Hyku themes to allow for a uniform layout on all pages addressing all five Bootstrap breakpoints. Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit ensures the home page of the Neutral Theme is fully responsive at all five Bootstrap breakpoints. Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit addresses header layout issues on the Cultural Theme home page by: - creating consistency in the size of the search bar across all break points - moving the hamburger menu to the right of the page when in mobile view - creating more consistency in styling of the facet "Browse by" across all breakpoints Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit addresses layout issues on the home page of the Institutional Theme by: - removing the hamburger menu since it was only holding the search bar - centering the application name in smaller breakpoints - setting the application name to the left next to the logo in larger breakpoints Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
This commit fixes the layout of the home page for the Default Theme in mobile view by adding spacing around the search form and aligning the user utility links to the right. Any changes to the page navigation section would require an override from Hyrax. Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 30, 2025
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 31, 2025
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Jan 31, 2025
This commit: - adds in the classes to the header that allowed for custom colorization and refined the responsive layout - Removes some of the padding in the footer to make it more compact in mobile view to account for the height of the body being set in Hyrax which assumes a footer height of 118px Ref: - notch8/palni_palci_knapsack#142
sjproctor
added a commit
to samvera/hyku
that referenced
this issue
Feb 1, 2025
This commit removes a negative margin on the featured collections column and removes a margin from the file img on the featured collections card to ensure the featured works and featured collections are aligned on the logged in home page and the logged out home page. Ref: - notch8/palni_palci_knapsack#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
As much as possible, changes should be made in Hyku as issues also exist there.
Details of issues (some have already been resolved)
Default Theme
The Recently Uploade works are displaying as code rather than thumbnails.
Screenshots
Currently Looks Like
It should look like
Cultural Theme
Recent Works section is not responsive. Users have to horizontally scroll when using a smaller screen size.
Video
Screen.Recording.2024-10-02.at.8.31.07.AM.mov
The featured Collections do not span the entire container like hykucommons. See screenshots.
Screenshots
Currently
HykuCommons
Institutional Theme
Does not carousel work types smoothly - moved to separate ticket
The footer is not the standard footer and forces the user to horizontally scroll. See screenshots.
Screenshots
[Currently](https://demo.palni-palci-staging.notch8.cloud/?locale=en)Screen.Recording.2024-10-02.at.8.39.51.AM.mov
HykuCommons Example
The Work Type banner has some funky behavior when you click the arrows to scroll. See video.
Video
[Currently](https://demo.palni-palci-staging.notch8.cloud/?locale=en)Screen.Recording.2024-10-02.at.8.43.46.AM.mov
HykuCommons
Screen.Recording.2024-10-02.at.8.44.40.AM.mov
Neutral Theme Home Page
Video
CurrentlyScreen.Recording.2024-10-02.at.8.48.28.AM.mov
HykuCommons
https://github.com/user-attachments/assets/c36d1dcd-26d2-4439-a502-07c9dcfa4971
Acceptance Criteria
Default Theme Home Page
Cultural Theme Home Page
Institutional Theme Home Page
The work types banner behaves like the HykuCommons versionMoved to Institutional Repository carousel does not work #189Neutral Theme Home Page
Color behavior
Notes:
There are expected revisions to the previous button color behavior.
Primary button behavior:
Default button behavior:
Testing Instructions (Current, use me!)
Testing (Old: rework was added but leaving this here for context)
In admin menu, set to theme: and compare to Demo Site.
Verify behavior for each of the 4 homepage themes: default, cultural, institutional, and neutral, specifically watching for items noted in the Acceptance Criteria section. Note: Due to hyrax, bootstrap and blacklight updates, as well as bug fixes, there will be some minor variations but overall look and feel should be similar and work correctly.
The text was updated successfully, but these errors were encountered: