Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page Themes #142

Open
6 of 7 tasks
jillpe opened this issue Oct 1, 2024 · 1 comment · Fixed by samvera/hyku#2417
Open
6 of 7 tasks

Home Page Themes #142

jillpe opened this issue Oct 1, 2024 · 1 comment · Fixed by samvera/hyku#2417
Assignees
Labels
High Priority needs rework issue needs additional work

Comments

@jillpe
Copy link

jillpe commented Oct 1, 2024

Summary

As much as possible, changes should be made in Hyku as issues also exist there.

Details of issues (some have already been resolved)

Default Theme

The Recently Uploade works are displaying as code rather than thumbnails.

Screenshots

Currently Looks Like

Image

It should look like
Image

Cultural Theme

Recent Works section is not responsive. Users have to horizontally scroll when using a smaller screen size.

Video
Screen.Recording.2024-10-02.at.8.31.07.AM.mov

The featured Collections do not span the entire container like hykucommons. See screenshots.

Screenshots

Currently
Image

HykuCommons
Image

Institutional Theme

Does not carousel work types smoothly - moved to separate ticket
The footer is not the standard footer and forces the user to horizontally scroll. See screenshots.

Screenshots [Currently](https://demo.palni-palci-staging.notch8.cloud/?locale=en)
Screen.Recording.2024-10-02.at.8.39.51.AM.mov

HykuCommons Example
Image

The Work Type banner has some funky behavior when you click the arrows to scroll. See video.

Video [Currently](https://demo.palni-palci-staging.notch8.cloud/?locale=en)
Screen.Recording.2024-10-02.at.8.43.46.AM.mov

HykuCommons

Screen.Recording.2024-10-02.at.8.44.40.AM.mov

Neutral Theme Home Page

  • Line with buttons below image should apparently overlay image
  • No outline around featured collections
  • The footer has a white bar underneath it. See video.
Video Currently
Screen.Recording.2024-10-02.at.8.48.28.AM.mov

HykuCommons
https://github.com/user-attachments/assets/c36d1dcd-26d2-4439-a502-07c9dcfa4971

Acceptance Criteria

Default Theme Home Page

  • 'Recently Uploaded' items display as thumbnails and title like hykucommons

Cultural Theme Home Page

  • Recent Works Section is responsive
  • Featured Collections span the entire container like HykuCommons

Institutional Theme Home Page

Neutral Theme Home Page

Color behavior

  • Go, Advanced, and All button colors behave consistently among all homepage themes

Notes:

There are expected revisions to the previous button color behavior.
Primary button behavior:

  • hover color option now controls background, border, and hover color of all primary buttons, such as homepage go button. This is new behavior, as previously the primary button color could not be modified. The hover color will be a darker version of the background.
  • primary button text color can now be set.

Default button behavior:

  • default button background color appears consistently on all "Secondary" button classes. The hover color is a darker version of the background.
  • default button text now applies consistently to secondary button class, and hover color remains the same
  • default button border color can also be set.

Testing Instructions (Current, use me!)

  • Test in staging
  • Check footer in all screen sizes
  • Default theme: check header in mobile view
  • Cultural theme: check header in all screen sizes
  • Institutional theme: check header in all screen sizes
  • Neutral theme: check page body in mobile view

Testing (Old: rework was added but leaving this here for context)

In admin menu, set to theme: and compare to Demo Site.

Verify behavior for each of the 4 homepage themes: default, cultural, institutional, and neutral, specifically watching for items noted in the Acceptance Criteria section. Note: Due to hyrax, bootstrap and blacklight updates, as well as bug fixes, there will be some minor variations but overall look and feel should be similar and work correctly.

  • Header looks as expected
  • Footer looks as expected
  • Content looks as expected
  • Responsive behavior works correctly
@jillpe jillpe converted this from a draft issue Oct 1, 2024
@jillpe jillpe changed the title Site defaults to Spanish Epic: Broken Themes Oct 1, 2024
@jillpe jillpe changed the title Epic: Broken Themes Default Theme Oct 1, 2024
@jillpe jillpe changed the title Default Theme Default Home Page Theme Oct 1, 2024
@jillpe jillpe changed the title Default Home Page Theme Home Page Themes Oct 2, 2024
@laritakr laritakr mentioned this issue Dec 2, 2024
19 tasks
@laritakr laritakr self-assigned this Jan 13, 2025
This was referenced Jan 16, 2025
@laritakr laritakr moved this from Ready for Development to Code Review in PalsKnapsack Jan 21, 2025
@github-project-automation github-project-automation bot moved this from Code Review to Done in PalsKnapsack Jan 21, 2025
@laritakr laritakr moved this from Done to In Development in PalsKnapsack Jan 21, 2025
@laritakr laritakr reopened this Jan 21, 2025
@github-project-automation github-project-automation bot moved this from In Development to Ready for Development in PalsKnapsack Jan 21, 2025
laritakr pushed a commit that referenced this issue Jan 21, 2025
Completes #142
laritakr pushed a commit that referenced this issue Jan 21, 2025
Complete #142
@laritakr laritakr moved this from Ready for Development to Code Review in PalsKnapsack Jan 21, 2025
@laritakr laritakr moved this from Code Review to Deploy to Staging in PalsKnapsack Jan 23, 2025
@laritakr laritakr moved this from Deploy to Staging to SoftServ QA in PalsKnapsack Jan 23, 2025
@sjproctor
Copy link
Contributor

sjproctor commented Jan 23, 2025

QA Results: Rework Needed

Rework Needed

Neutral Theme [mobile view]: layout issues

Image

Rework Suggested (Not strictly outlined in acceptance criteria, but may apply to this ticket)

Default Theme [mobile view]: add some space between the nav menu and search bar Image
All themes [mobile view]: footer text is scrunched and does not adjust to a column format like in HykuCommons Image
HykuCommons mobile view footer for comparison Image

Process

Default Theme

  • ✅ Confirmed the Recently Upload works are displaying as thumbnails not as code
  • ✅ Confirmed Header looks as expected
  • ✅ Confirmed Footer looks as expected - except in mobile
  • ✅ Confirmed Content looks as expected
  • **❌ Responsive behavior works correctly - nav bar menu and footer spacing + footer in all themes
  • ✅ Confirmed Go, Advanced, and All button colors behave consistently

Cultural Theme

  • ✅ Confirmed Recent Works section is now responsive
  • ✅ Featured Collections span the entire container like HykuCommons
  • ✅ Confirmed Header looks as expected - except in mobile
  • ✅ Confirmed Footer looks as expected - except in mobile
  • ✅ Content looks as expected
  • **❌ Responsive behavior works correctly - footer in all themes
  • ✅ Confirmed Go, Advanced, and All button colors behave consistently

Institutional Theme

  • ✅ Confirmed the footer is the standard footer, no horizontal scroll
  • ✅ Confirmed Header looks as expected - except in mobile
  • ✅ Confirmed Footer looks as expected - except in mobile
  • ✅ Confirmed Content looks as expected
  • **❌ Responsive behavior works correctly - footer in all themes
  • ✅ Confirmed Go, Advanced, and All button colors behave consistently

Neutral Theme

  • ✅ Confirmed line with buttons below image overlays image
  • ✅ Confirm there is an outline around featured collections
  • ✅ Confirmed the footer does not have a white bar underneath it
  • ✅ Confirmed Header looks as expected
  • ✅ Confirmed Footer looks as expected - except in mobile
  • ✅ Confirmed Content looks as expected
  • **❌ Responsive behavior works correctly - footer in all themes, right side section does not drop as expected, some horizontal scroll
  • ✅ Confirmed Go, Advanced, and All button colors behave consistently

@sjproctor sjproctor moved this from SoftServ QA to Ready for Development in PalsKnapsack Jan 23, 2025
@sjproctor sjproctor added the needs rework issue needs additional work label Jan 23, 2025
@sjproctor sjproctor moved this from Ready for Development to In Development in PalsKnapsack Jan 27, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit fixes the mobile layout of the Neutral Theme by adding a
media query to disable the flex property while in mobile view.

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit refactors the footer in all four Hyku themes to allow for a
uniform layout on all pages addressing all five Bootstrap breakpoints.

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit ensures the home page of the Neutral Theme is fully
responsive at all five Bootstrap breakpoints.

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit addresses header layout issues on the Cultural Theme home
page by:
- creating consistency in the size of the search bar across all break
points
- moving the hamburger menu to the right of the page when in mobile view
- creating more consistency in styling of the facet "Browse by" across
all breakpoints

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit addresses layout issues on the home page of the
Institutional Theme by:
- removing the hamburger menu since it was only
holding the search bar
- centering the application name in smaller breakpoints
- setting the application name to the left next to the logo in larger
breakpoints

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 30, 2025
This commit fixes the layout of the home page for the Default Theme
in mobile view by adding spacing around the search form and aligning
the user utility links to the right. Any changes to the page
navigation section would require an override from Hyrax.

Ref:
- notch8/palni_palci_knapsack#142
sjproctor added a commit to samvera/hyku that referenced this issue Jan 31, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Jan 31, 2025
This commit:
- adds in the classes to the header that allowed for custom colorization
and refined the responsive layout
- Removes some of the padding in the footer to make it more compact in
mobile view to account for the height of the body being set in Hyrax
which assumes a footer height of 118px

Ref:
- notch8/palni_palci_knapsack#142
@laritakr laritakr moved this from In Development to Code Review in PalsKnapsack Jan 31, 2025
@laritakr laritakr moved this from Code Review to Deploy to Staging in PalsKnapsack Jan 31, 2025
@laritakr laritakr moved this from Deploy to Staging to Code Review in PalsKnapsack Jan 31, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Feb 1, 2025
This commit removes a negative margin on the featured collections column
and removes a margin from the file img on the featured collections card
to ensure the featured works and featured collections are aligned on the
logged in home page and the logged out home page.

Ref:
- notch8/palni_palci_knapsack#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority needs rework issue needs additional work
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

3 participants