Refactor to use notation-core-go's SignatureEnvelope #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@priteshbandi this PR is difficult to review because |
|
@qmuntal Updated PR to not move files from |
jondonas
approved these changes
Jul 8, 2022
priteshbandi
force-pushed
the
main
branch
2 times, most recently
from
faf962b to
3b5638e
Compare
priteshbandi
commented
Jul 11, 2022
gokarnm
requested changes
Jul 11, 2022
gokarnm
approved these changes
Jul 11, 2022
3 tasks
added 3 commits
July 12, 2022 10:35
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
|
Mistakenly closed while trying to resolving merge conflicts..Reopening |
jondonas
approved these changes
Jul 12, 2022
JeyJeyGao
pushed a commit
to JeyJeyGao/notation-go
that referenced
this pull request
Jul 22, 2022
* Refactor to use notation-core-go's SignatureEnvelope * move code from signature/jws to signature Signed-off-by: Pritesh Bandi <[email protected]> Signed-off-by: Junjie Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Dependency
Because of dependent changes build will fail. Once dependent PR is approved I will update this PR with updated go.sum.
Signed-off-by: Pritesh Bandi [email protected]