Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable timestamping for signing and verification #78

Closed
priteshbandi opened this issue Jul 8, 2022 · 2 comments · Fixed by #418
Closed

Reenable timestamping for signing and verification #78

priteshbandi opened this issue Jul 8, 2022 · 2 comments · Fixed by #418
Assignees
@shizhMSFT
Milestone
1.2.0

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented Jul 8, 2022 •
edited by gokarnm
Loading

As part of #77(Refactor to use notation-core-go's SignatureEnvelope), we disabled time-stamping support for signing and verification workflows.

Action Required:

  1. Implement timestamping support in notation-core-go.
  2. Enable timestamping support for signing and verification workflows in notation-go.
  3. Review verify TSA code which includes CMS parsing and verification. This code was included in alpha.1 and did not get through enough code review.
  4. Ensure adequate test coverage in notation-core-go for CMS parsing and verification.
@priteshbandi priteshbandi mentioned this issue Jul 8, 2022
Merged
@dtzar dtzar mentioned this issue Jul 13, 2022
Open
1 task
@dtzar dtzar added this to the RC-1 milestone Jul 13, 2022
@iamsamirzon iamsamirzon mentioned this issue Jul 18, 2022
Closed
@gokarnm
Copy link

gokarnm commented Aug 10, 2022

@shizhMSFT I update the scope in the issue description as discussed earlier.

@yizha1 yizha1 modified the milestones: RC-1, Discuss Sep 21, 2022
@yizha1
Copy link
Contributor

yizha1 commented Sep 21, 2022

Based on the community discussion, move this issue out of rc.1 scope

@priteshbandi priteshbandi modified the milestones: Discuss, RC-2 Nov 23, 2022
@yizha1 yizha1 modified the milestones: RC-2, Discuss Dec 14, 2022
@shizhMSFT shizhMSFT mentioned this issue Jul 5, 2024
Merged
@yizha1 yizha1 modified the milestones: Discuss, 1.2.0 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shizhMSFT shizhMSFT

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

feat: Timestamp Two-Hearts/notation-go
5 participants
@dtzar @gokarnm @priteshbandi @shizhMSFT @yizha1