fix: updated error messages for certificate chain validation in x509 package #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 90.28% 90.32% +0.03%
==========================================
Files 14 16 +2
Lines 1390 1457 +67
==========================================
+ Hits 1255 1316 +61
- Misses 106 110 +4
- Partials 29 31 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
reviewed
Feb 9, 2023
JeyJeyGao
approved these changes
Feb 9, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
reviewed
Feb 10, 2023
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Feb 10, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would:
resolve #117
resolve #119
resolve #121
Signed-off-by: Patrick Zheng [email protected]