Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certificate chain validation error message is not returned #117

Closed
JeyJeyGao opened this issue Feb 7, 2023 · 1 comment · Fixed by #120
Closed

certificate chain validation error message is not returned #117

JeyJeyGao opened this issue Feb 7, 2023 · 1 comment · Fixed by #120
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented Feb 7, 2023

The error message for validate certificate is not returned. Here is code.

func isIssuedBy(subject *x509.Certificate, issuer *x509.Certificate) bool {
err := subject.CheckSignatureFrom(issuer)
return err == nil && bytes.Equal(issuer.RawSubject, subject.RawIssuer)
}

The subject.CheckSignatureFrom may return an error and the error message is not returned, which will finally cause an inaccurate error.

@JeyJeyGao JeyJeyGao added the enhancement New feature or request label Feb 7, 2023
@JeyJeyGao JeyJeyGao changed the title certificate chain validation error mession is not returned certificate chain validation error message is not returned Feb 7, 2023
@patrickzheng200 patrickzheng200 self-assigned this Feb 8, 2023
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Feb 8, 2023
@patrickzheng200
Copy link

I will take this one and go through notation-core-go for similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants