Remove more gtk #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Phillip Carter <[email protected]>
dotnet#9490 - Update error message placeholders to format error message correctly - Converted count up to count down to show properly how many more elements were requested but not fulfilled
* Update dependencies from https://github.com/dotnet/arcade build 20201111.5 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20561.5 * Update dependencies from https://github.com/dotnet/arcade build 20201113.2 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20563.2 * Update dependencies from https://github.com/dotnet/arcade build 20201116.3 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20566.3 * Update dependencies from https://github.com/dotnet/arcade build 20201117.7 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20567.7 * Update dependencies from https://github.com/dotnet/arcade build 20201123.2 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20573.2 * retain older sdk * Update dependencies from https://github.com/dotnet/arcade build 20201123.2 Microsoft.DotNet.Arcade.Sdk From Version 6.0.0-beta.20552.5 -> To Version 6.0.0-beta.20573.2 * retain 3.1 SDK Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brett V. Forsgren <[email protected]>
* Initial incremental build refactor * Get previous slot * Fixed build * Fixed timestamp max * Updating surface area * Fixing last test * Just return true * Add minor TODO * Change value name to something more coherent * Fixing test
…r of type `string`.
* Fix net sdk references discovery * Do numbers properly * version filter
* Copy XmlDocuments to output directory * feedback
Dev/nosami/fsharp interactive
VSMac already bundles it
FCS contains the following method
```fs
member _.CheckMaxMemoryReached() =
if not maxMemoryReached && GC.GetTotalMemory(false) > int64 maxMB * 1024L * 1024L then
Trace.TraceWarning("!!!!!!!! MAX MEMORY REACHED, DOWNSIZING F# COMPILER CACHES !!!!!!!!!!!!!!!")
// If the maxMB limit is reached, drastic action is taken
// - reduce strong cache sizes to a minimum
maxMemoryReached <- true
braceMatchCache.Resize(AnyCallerThread, newKeepStrongly=10)
backgroundCompiler.DownsizeCaches()
maxMemEvent.Trigger( () )
```
On the surface, this looks fine, but on Mono GC.GetTotalMemory can be
slow and it is called repeatedly.
Set maxMemoryReached via reflection to short circuit this code (which always
returns false anyway due to high maxMB setting)
Fix OptionsPanel leaks and API change
Merge fsharp-editor to net6
Dev/nosami/use main dotnet runtime
We don't use NavBar or breakpoint resolution in VSMac anyways
Remove two types from MEF that were causing MEF errors
``` /Users/builder/azdo/_work/1/s/main/external/fsharp-editor/vsintegration/src/FSharp.Editor/unknown(1,1): warning FS3384: The .NET SDK for this script could not be determined. If the script is in a directory using a 'global.json' then ensure the relevant .NET SDK is installed. The output from '/usr/local/share/dotnet/dotnet --version' in the directory '/Users/builder/azdo/_work/1/s/main/external/fsharp-editor/vsintegration/src/FSharp.Editor' was: 'Could not execute because the application was not found or a compatible .NET SDK is not installed.�Possible reasons for this include:� * You intended to execute a .NET program:� The application '--version' does not exist.� * You intended to execute a .NET SDK command:� A compatible installed .NET SDK for global.json version [5.0.100] from [/Users/builder/azdo/_work/1/s/main/external/fsharp-editor/global.json] was not found.� Install the [5.0.100] .NET SDK or update [/Users/builder/azdo/_work/1/s/main/external/fsharp-editor/global.json] with an installed .NET SDK:' and the exit code was '145'. [/Users/builder/azdo/_work/1/s/main/external/fsharp-editor/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj] ``` Bump the SDK version to avoid this.
Fix warning spam when building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.