This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1386635 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCS contains the following method
```fs
member _.CheckMaxMemoryReached() =
if not maxMemoryReached && GC.GetTotalMemory(false) > int64 maxMB * 1024L * 1024L then
Trace.TraceWarning("!!!!!!!! MAX MEMORY REACHED, DOWNSIZING F# COMPILER CACHES !!!!!!!!!!!!!!!")
// If the maxMB limit is reached, drastic action is taken
// - reduce strong cache sizes to a minimum
maxMemoryReached <- true
braceMatchCache.Resize(AnyCallerThread, newKeepStrongly=10)
backgroundCompiler.DownsizeCaches()
maxMemEvent.Trigger( () )
```
On the surface, this looks fine, but on Mono GC.GetTotalMemory can be
slow and it is called repeatedly.
Set maxMemoryReached via reflection to short circuit this code (which always
returns false anyway due to high maxMB setting)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCS contains the following method
On the surface, this looks fine, but on Mono, GC.GetTotalMemory can be
slow and it is called repeatedly.
Set maxMemoryReached via reflection to short circuit this code (which always
returns false anyway due to high maxMB setting)