Fix autocomplete problem #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the form to not auto complete what we wrote before by removing action="" and adding autocomplete="off" Making so now, especially when I'm on mobile I don't get my screen filled with previously typed sentences. This commit is related to erming#532
|
@nomadturk is there a reason that PR is not on erming's source repo ? |
|
Probably because I messed it up :D |
Repository owner
locked and limited conversation to collaborators
Jan 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the form to not auto complete what we wrote before by removing action="" and adding autocomplete="off"
This patch denies erming#518 and removes that. Because without autocomplete, writing suggestions for mobile keyboards was enabled but at the mean time also whenever you clicked on text area to write a new message, you were given a number of your last typed sentences. Especially on mobile, this was a huge buzzkill because after 3-5 sentences on any channel, these suggestions covered your whole screen.
So, in order to remove it I did some changes, ensuring writing suggestions still work.
I have added autocomplete=off .
This commit is related to erming#532
@JocelynDelalande you might give it a go. ;) I don't have google keyboard.