Revert "Revert "Turn off input autocomplete"" #532
Conversation
Turned of autocomplete again. Removed spellcheck. Added tabindex="1", before that when I clicked anywhere else on the page, tab button didn't go to text box at first try.
Changed show-more buttons position to relative to avoid it being displayed over the existing text. Due to changing Send button to an input class, some adjustments were needed for it's positioning.
|
Merged commits. |
|
@nomadturk Hi, and thanks for your contrib :) So what's actualy the goal of the whole PR ? hint: "Update index.html" is not a very helpfull commit message, cause meta-data already says it, it's better to adopt an intention/feature point of view while writing commits. |
|
Right, I didn't get into much detail since I was talked about it in irc but I forgot what happens when someone looks back to it a while later. There are 3 main things changed: 1- This patch denies #518 and removes that. Because without autocomplete, writing suggestions for mobile keyboards was enabled but at the mean time also whenever you clicked on text area to write a new message, you were given a number of your last typed sentences. Especially on mobile, this was a huge buzzkill because after 3-5 sentences on any channel, these suggestions covered your whole screen. So, in order to remove it I did some changes, ensuring writing suggestions still work. Along with these, I changed the "Send" button's type to input in the process. Due to these changes I needed to add/edit some css rules as mentioned above. I also added tabindex=1 to make the text box the first tab in order to trap us more to the chat box. Again, with this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. Lastly, when I last updated the files, I believe I didn't add anything so I believe it's only the meta data you see. Because what I did there was fixing my mistake of using spaces by replacing them again with tabs just like the rest of the file. I think this was it. |
|
Is it actually necessary to change the send button to an input element? |
|
Hi @nomadturk Thanks for all that, there is a lot of good stuff, it's the PR hiding the bugfixes forest ;-)
Ok, if I get it well, it will allow swiping/touch input to do suggestions, but disable suggestion of previous message that may cover the screen, right ?
I disagree, however it could be discussed, but in another PR, as it is another change.
Same question as @floogulinc , why is this needed ?
Cool thing, but should go in another PR.
That don't have to appear in git history, you have to merge the commit that added tabs with the one replacing them with spaces. From other contributors those as two separate commits are only noise.
Ok, so to sum it up, I think it's valuable contribution, but that needs to be reorganized, please
Once that is done, it could get merged/discussed feature by feature… and I will be all in favor :) (except spellchecking disabling). |
|
@JocelynDelalande seems to have taken first review for this PR, I'll take second review when he is OK with it. Thanks! |
|
@JocelynDelalande, any news regarding review for this PR? |
|
Hey there... Sorry, I'm out of the city and away from internet since a while and I'm busy till the end of this month. I am, however, planning to comply with the recommended changes above and submitting several PR's instead of one big chunky PR when I have time. |
|
@nomadturk cool :), waiting for your edits then, don't hesitate to mention my name on newly created PR, so that it triggers some notification to my inbox, for review. |
|
Hey @nomadturk, I see that you haven't got the time to get back to this PR :-( |
Updated the form to not auto complete what we wrote before by removing action="" and adding autocomplete="off" Making so now, especially when I'm on mobile I don't get my screen filled with previously typed sentences. This commit is related to erming#532
|
OK, I have created only two PR's for now. I really don't recall why I changed the Send button to an input as well as input type of it. Maybe it was to make them look better. I'll do further tests and make a PR if need be. Spellcheck, well, I personally chose not to share words all the time. Sometimes it's really disturbing to see your messages being corrected. But well, since it was a personal call, I didn't think people will want it. So, I won't be adding it. As for tabindex, I tried it on IE, Chrome, Firefox and it was locked into the text box. So, cancel that as well. That's all. We shall continue at the new PR #'s. |
index.html
Turned of autocomplete again. Removed spellcheck.
Added tabindex="1", before that when I clicked anywhere else on the page, tab button didn't go to text box at first try.
Replaced button with an input.
style.css
Changed show-more buttons position to relative to avoid it being displayed over the existing text.
Due to changing Send button to an input class, some adjustments were needed for it's positioning.