chore: move tests from noir_stdlib to test_programs
#5608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-workspace to ensure zero stdlib tests
github-actions
bot
added
the
documentation
|
🚀 Deployed on https://66a2b4c51bacb9ad61816df8--noir-docs.netlify.app |
|
FYI @noir-lang/developerrelations on Noir doc changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Part of #5427
Summary*
When looking for existing tests of
derive_pedersen_generators, I discovered a nice set of tests innoir_stdlib.However, those tests are never run in CI and fail on master: the
noir_stdlibhas already been included in theFileManager/Workspace, so it fails with duplicate definition errors.Additional Context
I also added job to our test workflow that bans any tests in
noir_stdlib.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.