Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit preparedness: test crypto functions #5427

Closed
1 of 14 tasks
michaeljklein opened this issue Jul 5, 2024 · 0 comments · Fixed by #5614
Closed
1 of 14 tasks

Audit preparedness: test crypto functions #5427

michaeljklein opened this issue Jul 5, 2024 · 0 comments · Fixed by #5614
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

michaeljklein commented Jul 5, 2024 •
edited
Loading

Problem

Part of #5362

// ssa/ir/instruction.rs
pub(crate) enum Intrinsic {
  • DerivePedersenGenerators (there are good tests in stdlib)
pub enum BlackBoxFunc {
  • AES128Encrypt
  • SHA256
  • Blake2s
  • Blake3
  • SchnorrVerify
  • PedersenCommitment
  • PedersenHash
  • EcdsaSecp256k1
  • EcdsaSecp256r1
  • Keccak256
  • Keccakf1600
  • Poseidon2Permutation
  • Sha256Compression

Happy Case

Test all listed functions

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@michaeljklein michaeljklein added the enhancement New feature or request label Jul 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 5, 2024
@michaeljklein michaeljklein mentioned this issue Jul 5, 2024
Open
This was referenced Jul 25, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@michaeljklein
chore: crypto blackbox tests (#5614)
86c151a 
# Description

## Problem\*

Resolves #5427

## Summary\*

Unit test our blackbox crypto instructions.

Preferable to merge after:
- #5559
- #5484

(Because of overlapping helper functions)

## Additional Context

While most of our crypto function implementations are from external
crates, `poseidon2_permutation` is implemented internally. I'm using the
[`zkhash` crate](https://docs.rs/zkhash/0.2.0/zkhash/poseidon2/) to test
our implementation.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: crypto blackbox tests noir-lang/noir
1 participant
@michaeljklein