Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove TypeVariableId from Generics #4059

Merged
merged 2 commits into from
Jan 17, 2024
Merged

chore: Remove TypeVariableId from Generics #4059

merged 2 commits into from
Jan 17, 2024

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jan 16, 2024

Description

Problem*

Resolves #4058

Summary*

Small cleanup from the trait generics PR. Since TypeVariableIds are no longer needed in Generics, this removes them.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

TomAFrench
TomAFrench approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment nits

compiler/noirc_frontend/src/node_interner.rs Outdated Show resolved Hide resolved
compiler/noirc_frontend/src/node_interner.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench enabled auto-merge January 17, 2024 11:54
@TomAFrench TomAFrench added this pull request to the merge queue Jan 17, 2024
Merged via the queue into master with commit 71d6514 Jan 17, 2024
30 checks passed
@TomAFrench TomAFrench deleted the jf/fix-4058 branch January 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove TypeVariableId from Generics
2 participants
@jfecher @TomAFrench