Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TypeVariableId from Generics #4058

Closed
jfecher opened this issue Jan 16, 2024 · 0 comments · Fixed by #4059
Closed

Remove TypeVariableId from Generics #4058

jfecher opened this issue Jan 16, 2024 · 0 comments · Fixed by #4059
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.24

Comments

@jfecher
Copy link
Contributor

jfecher commented Jan 16, 2024 •
edited
Loading

Problem

After #4000 was merged, TypeVariables now contain their original TypeVariableId themselves. So there is no longer any need to also store these separately alongside type variables in Generics.

Happy Case

We can remove the duplicate TypeVariableIds.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@jfecher jfecher added the enhancement New feature or request label Jan 16, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 16, 2024
@kevaundray kevaundray added the good first issue Good for newcomers label Jan 16, 2024
@kevaundray kevaundray added this to the 0.24.0 milestone Jan 16, 2024
@jfecher jfecher changed the title Remove TypeVariableId from Generics and TypeBindings Remove TypeVariableId from Generics Jan 16, 2024
@jfecher jfecher mentioned this issue Jan 16, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
@jfecher @TomAFrench
chore: Remove TypeVariableId from Generics (#4059)
71d6514 
# Description

## Problem\*

Resolves #4058 

## Summary\*

Small cleanup from the trait generics PR. Since `TypeVariableId`s are no
longer needed in `Generics`, this removes them.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Noir
Archived in project
Milestone
0.24
Development

Successfully merging a pull request may close this issue.

chore: Remove TypeVariableId from Generics noir-lang/noir
2 participants
@jfecher @kevaundray