Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Remove add_file and file_reader from FileManager #3762

Merged
merged 6 commits into from
Dec 11, 2023
Merged

chore!: Remove add_file and file_reader from FileManager #3762

merged 6 commits into from
Dec 11, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This removes FileManager from add_file and uses add_file_with_source

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore: Remove add_file from FileManager chore!: Remove add_file from FileManager Dec 11, 2023
@kevaundray kevaundray changed the title chore!: Remove add_file from FileManager chore!: Remove add_file from FileManager Dec 11, 2023
@kevaundray kevaundray changed the title chore!: Remove add_file from FileManager chore!: Remove add_file and file_reader from FileManager Dec 11, 2023
@kevaundray
chore: try using two methods for adding files; one which assumes the …
1e2d4e4 
…path is canonical and the other which adds the root and canonicalizes (#3763)

# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
jfecher
jfecher reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for this change?

@kevaundray
Copy link
Contributor Author

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

@kevaundray kevaundray marked this pull request as ready for review December 11, 2023 17:38
@kevaundray kevaundray merged commit 5b867d5 into kw/make-fm-read-only Dec 11, 2023
33 checks passed
@kevaundray kevaundray deleted the kw/remove-add-file-fm branch December 11, 2023 17:38
@kevaundray
Copy link
Contributor Author

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

Should have made this clear good ser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @jfecher