Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: try using two methods for adding files; one which assumes the path is canonical and the other which adds the root and canonicalizes #3763

Merged
merged 3 commits into from
Dec 11, 2023
Merged

chore: try using two methods for adding files; one which assumes the path is canonical and the other which adds the root and canonicalizes #3763

merged 3 commits into from
Dec 11, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

This essentially allows us to not special case the stdlib in the FileManager

@kevaundray kevaundray marked this pull request as ready for review December 11, 2023 15:30
@kevaundray kevaundray merged commit 1e2d4e4 into kw/remove-add-file-fm Dec 11, 2023
33 checks passed
@kevaundray kevaundray deleted the kw/diff-api-canonical-paths branch December 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kevaundray