feat: Replace Backend involvement in execution with barretenberg_black_box_solver crate
#2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
barretenberg_black_box_solver crate to remove Backend involvement in executionBackend involvement in execution with barretenberg_black_box_solver crate
2 tasks
2 tasks
* master: chore: improve error message for InternalError (#2429) chore: Add stdlib to every crate as it is added to graph (#2392) feat: create equivalence relationships for intermediate witnesses from multiplication (#2414) chore(ci): Fix version of `cross` to 0.2.5 (#2426) fix: Correct off-by-one errors in lexer spans (#2393)
|
This currently bumps binary sizes by ~4-5MB |
|
Ah, I imagine this will fail due to needing extra tweaks to flake setup for macos. |
|
Closing in favour of noir-lang/acvm#494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #2422
Resolves noir-lang/acvm#492
Summary*
The PR vendors the
BlackBoxFunctionSolverimplementation fromacvm-backend-barretenberginto a new cratebarretenberg_black_box_solver.Draft until we remove this implementation from
acvm-backend-barretenbergto avoid blowing up the binary size.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.