This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
chore!: Remove BlackBoxFunctionSolver implementation
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
remove-black-box-solver
branch
from
ef314e9 to
babe3c8
Compare
* kw/dyn-backends: Empty-Commit Empty-Commit chore: remove unnecessary `return` chore: remove unnecessary `match` tmate debug fix gates command update to 0.4.5 Update src/bb/mod.rs set env variables once all checks have passed add code to support arm64 unused import now using version 0.4.4 zipped path has been fixed chore: use WASM backend for blackbox functions exclusively and remove nix flake testing (#251) use nix develop sandbox issue? Update .github/workflows/test.yml chore(ci): create cache entries even if tests fail (#252) try large mac
* kw/dyn-backends: 0.4.6 remove tmate
* kw/dyn-backends: chore: remove stale comment chore: use proper ci runner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This responsibility is being offloaded to
nargoin noir-lang/noir#2423 so we no longer need the overhead of including this implementation here.This relies on a new release of ACVM to allow
Backendto not implementBlackBoxFunctionSolver.Additional Context
PR Checklist*
cargo fmton default settings.