Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup logic in mul_with_witness #1980

Merged
merged 10 commits into from
Jul 24, 2023
Merged

chore: cleanup logic in mul_with_witness #1980

merged 10 commits into from
Jul 24, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This cleans it up so that its commented and specifies exactly the optimizations being applied

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

TomAFrench
TomAFrench requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra documentation but this removes some optimisations from the previous implementation.

crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/sort.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/sort.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/sort.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench changed the title chore: cleanup logic in mul_with_witness chore: cleanup logic in mul_with_witness Jul 20, 2023
This was referenced Jul 20, 2023
Closed
Merged
@kevaundray kevaundray requested a review from TomAFrench July 23, 2023 12:13
TomAFrench
TomAFrench previously approved these changes Jul 24, 2023
View reviewed changes
@TomAFrench TomAFrench enabled auto-merge July 24, 2023 03:08
@TomAFrench TomAFrench disabled auto-merge July 24, 2023 03:10
@TomAFrench TomAFrench enabled auto-merge July 24, 2023 03:11
@TomAFrench TomAFrench added this pull request to the merge queue Jul 24, 2023
Merged via the queue into master with commit 5526c52 Jul 24, 2023
@TomAFrench TomAFrench deleted the kw/cleanup-mul-with-witness-logic branch July 24, 2023 05:01
@TomAFrench TomAFrench mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevaundray @TomAFrench