Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Expose mul_with_witness functionality from acvm stdlib #450

Closed
TomAFrench opened this issue Jul 24, 2023 · 0 comments
Closed

Expose mul_with_witness functionality from acvm stdlib #450

TomAFrench opened this issue Jul 24, 2023 · 0 comments
Labels
E-LOW Effort - Low (days) enhancement New feature or request P-LOW Priority - Low

Comments

@TomAFrench
Copy link
Member

Problem

As noted here, we have two separate implementations of mul_with_witness in Noir and ACVM which adds unnecessary duplication.

Happy Case

We should have a single canonical implementation exposed by ACVM which can be used up in Noir. This is slightly complicated by the fact that they track the new witnesses created in different ways (c.f. noir-lang/noir#1980).

We'll then need to modify this to take a closure which will allow the caller to inject the witness to use for multiplication while handling the witness creation themselves.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@TomAFrench TomAFrench added the enhancement New feature or request label Jul 24, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 24, 2023
@TomAFrench TomAFrench added E-LOW Effort - Low (days) P-LOW Priority - Low labels Aug 10, 2023
@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E-LOW Effort - Low (days) enhancement New feature or request P-LOW Priority - Low
Projects
Archived in project
Development

No branches or pull requests

2 participants