chore: move printing errors to nargo_cli
#1542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevaundray, what do you think about it? |
kevaundray
reviewed
Jun 7, 2023
| @@ -45,7 +45,7 @@ pub(crate) enum CliError<B: Backend> { | |||
|
|
|||
| /// Error while compiling Noir into ACIR. | |||
| #[error("Failed to compile circuit")] | |||
| CompilationError, | |||
| CompilationError(#[from] noirc_errors::Error), | |||
There was a problem hiding this comment.
How does this work if a program returns more than one error?
There was a problem hiding this comment.
There will be problems with this, but maybe we can go and do something like this:
|
From the perspective of the LSP, this PR doesn't really provide the diagnostic information that is needed when a compilation fails. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move printing errors to
nargo_cliProblem
Resolves #1530
PR Checklist
cargo fmton default settings.