Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileManager should be controlled by nargo #1599

Closed
phated opened this issue Jun 7, 2023 · 0 comments · Fixed by #1881
Closed

FileManager should be controlled by nargo #1599

phated opened this issue Jun 7, 2023 · 0 comments · Fixed by #1881
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jun 7, 2023

Problem

Currently, the FileManager is defaulted in noirc_frontend::hir::Context. This has lead to a poor API in #1598 where I needed to add file_manager() -> &FileManager to get a reference to the internal files and report warnings/errors from compilation.

Happy Case

The FileManager should be constructed outside the driver and passed in by reference. This way, the code creating a driver (such as nargo_cli) is in control of the FileManager itself.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@phated phated added the enhancement New feature or request label Jun 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 7, 2023
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Jul 13, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant