You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the FileManager is defaulted in noirc_frontend::hir::Context. This has lead to a poor API in #1598 where I needed to add file_manager() -> &FileManager to get a reference to the internal files and report warnings/errors from compilation.
Happy Case
The FileManager should be constructed outside the driver and passed in by reference. This way, the code creating a driver (such as nargo_cli) is in control of the FileManager itself.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Problem
Currently, the FileManager is defaulted in
noirc_frontend::hir::Context
. This has lead to a poor API in #1598 where I needed to addfile_manager() -> &FileManager
to get a reference to the internal files and report warnings/errors from compilation.Happy Case
The FileManager should be constructed outside the driver and passed in by reference. This way, the code creating a driver (such as nargo_cli) is in control of the FileManager itself.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: