Remove all version data and combine 33 commits to 1. #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add http module and documention, including fix httpclient bug.
|
I'm really keen on getting an actual HTTP client implementation into NodeMCU. I haven't had a chance to play/test this one, but 👍 in theory! :) |
|
Well, it's not without its shortcomings, notably in its error reporting. It took me some time to work out that a status of -1 was because the page I was fetching was too big. That said, I'd rather have this module than not have it, and it seems like a good starting point for further improvements. The module appears sound and I haven't run into any memory leaks. Any objections before I merge this? |
jmattsson
pushed a commit
that referenced
this pull request
Jan 15, 2016
Add HTTP client module and documents.
Too late 😉
Also, it needs to be added to https://github.com/nodemcu/nodemcu-firmware/wiki/Module-origin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all version data and combine 33 commits to 1. Add http module and documention, including fix httpclient bug. etc.
#886 (comment)