Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the HTTP client module #941

Closed
marcelstoer opened this issue Jan 15, 2016 · 6 comments
Closed

Clean up the HTTP client module #941

marcelstoer opened this issue Jan 15, 2016 · 6 comments

Comments

@marcelstoer
Copy link
Member

See #887 (comment):

  • write documentation
  • move examples from README to examples dir
@jmattsson
Copy link
Member

Somewhere/somewhen I volunteered to write the API docs for it. I've got it on my todo list, either this weekend or early next.

@jmattsson
Copy link
Member

I've added module docs to newdocs

@jmattsson
Copy link
Member

Considering the module docs include examples, should they perhaps just be removed from the readme? (as opposed to moved elsewhere)

@devsaurus
Copy link
Member

Guess so, #771 also proposes to remove examples from the README.
My approach is to have code snippets in the module docs, but to store full-fledged scripts that can actually be executed in lua/examples.

@TerryE
Copy link
Collaborator

TerryE commented Jan 16, 2016

I think that the current code snippets can be very misleading. I would prefer every module to have at least one full-fledged script which demonstrates best practice in using the module, and that this is in lua_examples not lua/examples.

@marcelstoer
Copy link
Member Author

Indeed, as per #771 and #772 full-fledged examples, not to be mixed up with the snippets in the docs, should be removed from README.

marcelstoer added a commit to marcelstoer/nodemcu-firmware that referenced this issue Jan 24, 2016
marcelstoer added a commit to marcelstoer/nodemcu-firmware that referenced this issue Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants