Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcp23017 Lua module #3067

Closed
wants to merge 66 commits into from
Closed

mcp23017 Lua module #3067

wants to merge 66 commits into from

Conversation

plomi-net
Copy link
Contributor

Fixes #3057

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

Add MCP23017 port expander support as a lua module. See issue #3057

TerryE and others added 30 commits July 23, 2019 19:16
Lua 5.1 to 5.3 realignement phase 1
The internal implementation already preferentially forwards to the
encoder module, so we should just remove these functions as they confuse
people into thinking that we don't have their inverses (see the feature
request #2907).

Update the docs to refer to the encoder version and add deprecation
warnings to the runtime implementations.
* clean effects library
* Fix several issues in ws2812 and effects
* Implement working way of calling shift from callback
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
#2819 has landed, now
that #2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
* Remove stale putative MD2 support

This hasn't worked in a while, presumably since one of our upstream
merges.  Don't bother making it work, since MD2 is generally considered
insecure.

* Land mbedtls 2.16.3-77-gf02988e57

* TLS: remove some dead code from espconn_mbedtls

There was some... frankly kind of scary buffer and data shuffling if
ESP8266_PLATFORM was defined.  Since we don't, in fact, define that
preprocessor symbol, just drop the code lest anyone (possibly future-me)
be scared.

* TLS: espconn_mbedtls: run through astyle

No functional changes

* TLS: espconn_mbedtls: put the file_params on the stack

There's no need to malloc a structure that's used only locally.

* TLS: Further minor tidying of mbedtls glue

What an absolute shitshow this is.  mbedtls should absolutely not
be mentioned inside sys/socket.h and app/mbedtls/app/lwIPSocket.c is not
so much glue as it as a complete copy of a random subset of lwIP; it
should go, but we aren't there yet.

Get rid of the mysterious "mbedlts_record" struct, which housed merely a
length of bytes sent solely for gating the "record sent" callback.

Remove spurious __attribute__((weak)) from symbols not otherwise
defined and rename them to emphasize that they are not actually part of
mbedtls proper.

* TLS: Rampage esp mbedtls glue and delete unused code

This at least makes the shitshow smaller

* TLS: lwip: fix some memp definitions

I presume these also need the new arguments

* TLS: Remove more non-NodeMCU code from our mbedtls

* TLS: drop support for 1.1

Depending on who you ask it's either EOL already or EOL soon, so
we may as well get rid of it now.
* Add missing globals from luacheck config

* Fix luacheck warnings in all lua files

* Re-enable luacheck in Travis

* Speed up Travis by using preinstalled LuaRocks

* Fix more luacheck warnings in httpserver lua module

* Fix DCC module and add appropriate definitions to luacheck config.

* Change inline comments from ignoring block to only ignore specific line

* Add Luacheck for Windows and enable it for both Windows and Linux

* Change luacheck exceptions and fix errors from 1st round of polishing

* Add retry and timeout params to wget
Also clean-up a nasty `ow` module example.
@plomi-net plomi-net requested a review from nwf May 13, 2020 09:58
@marcelstoer marcelstoer changed the title adding mcp23017 support as a lua module mcp23017 Lua module May 18, 2020
@nwf nwf added this to the Next release milestone Jun 19, 2020
plomi-net added 4 commits July 5, 2020 09:24
# Conflicts:
#	app/coap/endpoints.c
#	app/driver/input.c
#	app/include/task/task.h
#	app/lua/lauxlib.c
#	app/lua/lauxlib.h
#	app/lua/lbaselib.c
#	app/lua/ldblib.c
#	app/lua/lflash.c
#	app/lua/lnodemcu.c
#	app/lua/loadlib.c
#	app/lua/lobject.h
#	app/lua/lua.c
#	app/lua/lua.h
#	app/lua53/Makefile
#	app/mbedtls/app/espconn_mbedtls.c
#	app/mbedtls/app/lwIPSocket.c
#	app/modules/dcc.c
#	app/modules/hx711.c
#	app/modules/mqtt.c
#	app/modules/net.c
#	app/modules/node.c
#	app/modules/pipe.c
#	app/modules/rc.c
#	app/modules/softuart.c
#	app/modules/somfy.c
#	app/modules/tmr.c
#	app/modules/uart.c
#	app/modules/ws2812.c
#	app/modules/ws2812_effects.c
#	app/platform/platform.c
#	app/platform/platform.h
#	app/user/user_main.c
#	docs/modules/sqlite3.md
#	docs/modules/tls.md
#	lua_examples/luaOTA/_doTick.lua
#	lua_examples/telnet/README.md
#	lua_examples/telnet/telnet_fifosock.lua
#	lua_modules/ftp/ftpserver.lua
#	lua_tests/mispec.lua
@HHHartmann
Copy link
Member

If you have trouble rebasing your PR maybe have a look at #3174

plomi-net added a commit to plomi-net/nodemcu-firmware that referenced this pull request Jul 5, 2020
@plomi-net plomi-net marked this pull request as draft July 5, 2020 12:06
@plomi-net plomi-net mentioned this pull request Jul 5, 2020
4 tasks
@plomi-net
Copy link
Contributor Author

rebase doesn't working correctly in my repo. Sorry.
I've created a new PR, #3197
The remarks have been implemented.

@plomi-net plomi-net closed this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.