support for dhcp ntp server (option 42) reloaded #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjsg
reviewed
Mar 29, 2019
pjsg
reviewed
Mar 29, 2019
4 tasks
|
Needs to resolve the conflict in |
HHHartmann
force-pushed
the
dhcp_ntp-server
branch
from
88d5ec6 to
32b512f
Compare
marcelstoer
requested changes
Jul 26, 2019
marcelstoer
approved these changes
Jul 27, 2019
nwf
added a commit
to nwf/nodemcu-firmware
that referenced
this pull request
Jul 27, 2019
This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and `getmac` calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead. The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where nodemcu#2819 has landed, now that nodemcu#2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.
4 tasks
nwf
added a commit
to nwf/nodemcu-firmware
that referenced
this pull request
Jul 27, 2019
This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and `getmac` calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead. The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where nodemcu#2819 has landed, now that nodemcu#2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.
marcelstoer
pushed a commit
that referenced
this pull request
Dec 9, 2019
* Remove app/include/netif/wlan_lwip_if.h This file appears to be unused in our tree. * New `net.if.info` call to show LwIP information This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and `getmac` calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead. The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where #2819 has landed, now that #2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.
vsky279
pushed a commit
to vsky279/nodemcu-firmware
that referenced
this pull request
Dec 27, 2019
* Remove app/include/netif/wlan_lwip_if.h This file appears to be unused in our tree. * New `net.if.info` call to show LwIP information This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and `getmac` calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead. The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where nodemcu#2819 has landed, now that nodemcu#2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.
marcelstoer
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Remove app/include/netif/wlan_lwip_if.h This file appears to be unused in our tree. * New `net.if.info` call to show LwIP information This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and `getmac` calls. I don't propose to deprecate those, but perhaps we should, in the documentation, point users at this function instead. The direct motivation is to permit continued use of DHCP-provided NTP servers in a future where #2819 has landed, now that #2709 is in the tree. But rather than exposing just that information, a more general interface seems useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2651.
devbranch rather than formaster.docs/en/*. (why do I get an old template here with wrong path /en)support for ntp server offered via dhcp (option 42)
since #2660 is unchanged for over one month I try this one.
I took the changes of #2660 and added some fixes
Tested with DHCP server with and without this feature