Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect-based testing framework #2983

Closed
wants to merge 29 commits into from
Closed

Conversation

nwf
Copy link
Member

@nwf nwf commented Dec 24, 2019

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.

This adds a new flavor of NodeMCU self-tests: host-executed Expect programs that directly walk a physical module through its paces. At the moment I have examples for file and tls, both with fairly limited coverage, but I think this is a good approach for the kinds of testing discussed in #2145. This is just a start; any and all commentary, suggestions, and contributions are welcome.

TerryE and others added 21 commits July 23, 2019 19:16
Lua 5.1 to 5.3 realignement phase 1
The internal implementation already preferentially forwards to the
encoder module, so we should just remove these functions as they confuse
people into thinking that we don't have their inverses (see the feature
request nodemcu#2907).

Update the docs to refer to the encoder version and add deprecation
warnings to the runtime implementations.
* clean effects library
* Fix several issues in ws2812 and effects
* Implement working way of calling shift from callback
* Remove app/include/netif/wlan_lwip_if.h

This file appears to be unused in our tree.

* New `net.if.info` call to show LwIP information

This is a generalization of `wifi.sta`'s and `wifi.ap`'s `getip` and
`getmac` calls.  I don't propose to deprecate those, but perhaps we
should, in the documentation, point users at this function instead.

The direct motivation is to permit continued use of DHCP-provided NTP
servers in a future where
nodemcu#2819 has landed, now
that nodemcu#2709 is in the
tree.  But rather than exposing just that information, a more general
interface seems useful.
@nwf nwf changed the title Dev expect tests Add expect-based testing framework Dec 24, 2019
@nwf nwf mentioned this pull request Dec 24, 2019
4 tasks
nwf added 2 commits December 26, 2019 18:31
This is probably unnecessary, but it served as a useful stepping stone
while building the expect-based library.  Probably an on-module test is
better for `file` and friends.
This one requires much more active participation on the host
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants