-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol is undefined in IE11 #364
Comments
Thanks for reporting this. Would you have time to send a PR for this? |
@mcollina would you say the appropriate solution would be to feature test Symbol and just not define asyncIterator if it's not available? |
This was referenced Sep 24, 2018
Yea that sounds like a good approach to me
…On Mon, Sep 24, 2018, 18:58 John Hiesey ***@***.***> wrote:
@mcollina <https://github.com/mcollina> would you say the appropriate
solution would be to feature test Symbol and just not define asyncIterator
if it's not available?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW_VTH-4p1fqHuz1a-4Lr1fcGcZMtCqks5ueVWOgaJpZM4W3hjO>
.
|
OK, so once that's fixed there's a second issue here: readable-stream/lib/_stream_readable.js Line 357 in e890201
|
jhiesey
added a commit
to jhiesey/readable-stream
that referenced
this issue
Sep 24, 2018
* Polyfill Number.isNaN * Don't create Symbol.asyncIterator if Symbol is not defined Fixes nodejs#364
This was referenced Sep 24, 2018
Closed
jhiesey
added a commit
to jhiesey/readable-stream
that referenced
this issue
Sep 25, 2018
* Polyfill Number.isNaN * Don't create Symbol.asyncIterator if Symbol is not defined Fixes nodejs#364
jhiesey
added a commit
to jhiesey/readable-stream
that referenced
this issue
Sep 25, 2018
* Polyfill Number.isNaN * Don't create Symbol.asyncIterator if Symbol is not defined Fixes nodejs#364
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In IE11, I get
The error is coming from
readable-stream/lib/_stream_readable.js
Line 944 in bbc3ddc
The text was updated successfully, but these errors were encountered: