Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol is undefined in IE11 #364

Closed
jhiesey opened this issue Sep 24, 2018 · 5 comments
Closed

Symbol is undefined in IE11 #364

jhiesey opened this issue Sep 24, 2018 · 5 comments

Comments

@jhiesey
Copy link

jhiesey commented Sep 24, 2018

In IE11, I get

SCRIPT5009: 'Symbol' is undefined

The error is coming from

Readable.prototype[Symbol.asyncIterator] = function () {

@mcollina
Copy link
Member

Thanks for reporting this. Would you have time to send a PR for this?

@jhiesey
Copy link
Author

jhiesey commented Sep 24, 2018

@mcollina would you say the appropriate solution would be to feature test Symbol and just not define asyncIterator if it's not available?

@mafintosh
Copy link
Member

mafintosh commented Sep 24, 2018 via email

@jhiesey
Copy link
Author

jhiesey commented Sep 24, 2018

OK, so once that's fixed there's a second issue here:

if (Number.isNaN(n)) {

SCRIPT438: Object doesn't support property or method 'isNaN'

jhiesey added a commit to jhiesey/readable-stream that referenced this issue Sep 24, 2018
* Polyfill Number.isNaN
* Don't create Symbol.asyncIterator if Symbol is not defined

Fixes nodejs#364
jhiesey added a commit to jhiesey/readable-stream that referenced this issue Sep 25, 2018
* Polyfill Number.isNaN
* Don't create Symbol.asyncIterator if Symbol is not defined

Fixes nodejs#364
jhiesey added a commit to jhiesey/readable-stream that referenced this issue Sep 25, 2018
* Polyfill Number.isNaN
* Don't create Symbol.asyncIterator if Symbol is not defined

Fixes nodejs#364
@jhiesey
Copy link
Author

jhiesey commented Oct 1, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants