fix: fix >150mb bodies from crashing #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jhiesey :) |
|
I think this looks fine. This won't work in IE10, but I think it's time to stop supporting that anyway. I'm going to go in and rip out older IE support, then release this as a new major version. |
|
So this is merged, but I want to wait to release v3.0.0 until nodejs/readable-stream#364 is fixed |
4 tasks
|
Released as v3.0.0 |
lidel
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Oct 4, 2018
Switching to latest version with the fix by @hugomrdias \o/ Context: jhiesey/stream-http#93 Closes #654 License: MIT Signed-off-by: Marcin Rataj <[email protected]>
alanshaw
pushed a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Oct 9, 2018
Switching to latest version with the fix by @hugomrdias \o/ Context: jhiesey/stream-http#93 Closes #654 License: MIT Signed-off-by: Marcin Rataj <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes lots of problems with large http bodies
Related
ipfs-inactive/js-ipfs-http-client#654
ipfs-inactive/js-ipfs-http-client#788
ipfs-inactive/js-ipfs-http-client#788
just to reference a few we have lots of these.