-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration file for Crowdin integration #2344
Conversation
@Andrulko Amazing, that's really helpful. Will start working on it shortly |
I don't understand how CrowdIn works exactly, so I'm disinclined to review this myself, but it would be great if we could get some reviews and get it landed (or closed if it's not something we want to land, but I suspect we do). @nodejs/website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @Andrulko 👍
LGTM. Thanks for contribution @Andrulko 😃 |
Sure, I have very busy week now, so haven't enough time for that. Will check it |
Should content start showing up on https://crowdin.com/project/nodejs or are there further steps required for this to work? |
/ping @nodejs/i18n |
Yes. There's content now at https://crowdin.com/project/nodejs that's ready to be translated. At present it's necessary for someone to manually update the source English content by running a script: https://github.com/nodejs/i18n/blob/96e86dd8177975e104aac2151026d194f690093d/package.json#L19 The script downloads docs for the Node.js versions specified here: https://github.com/nodejs/i18n/blob/96e86dd8177975e104aac2151026d194f690093d/package.json#L5-L9 Whenever the It looks like @alexandrtovmach updated this content 2 months ago in nodejs/i18n#199 so the content in Crowdin is relatively up to date. |
Looks like the i18n repo stuff is for the nodejs/node API translations. Looks like Crowdin might need a seperate project to point to this repo and content |
Oh, maybe it's this one https://crowdin.com/project/nodejs-website, but there is no content in that project |
@nschonni I'm working on it |
Oh sorry I misread your earlier comment @nschonni. There are indeed two projects in Crowdin. We are hoping to be able to share user permissions, Translation Memory, etc across the two. |
Cool, I wondering if it will figure out the already translated stuff once https://support.crowdin.com/github-integration/ is setup |
You already have translations for Markdown files, so importing .md files with
content_segmentation: 0
is a good idea, it will segment content by paragraphs and integration will automatically import existing translations to Crowdin (e.g. 1st paragraph in translated file is imported to the 1st paragraph in the source file).A bit customized language codes are used for Portuguese, Brazilian and Chinese, thus languages mapping was added to fit your current folder names (e.g.
pt-br
).Hope it helps to start faster!