Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

collected new content #199

Merged
merged 3 commits into from
Jul 12, 2019
Merged

collected new content #199

merged 3 commits into from
Jul 12, 2019

Conversation

alexandrtovmach
Copy link
Contributor

Regarding discussion #72 this PR contain the newest docs content

@zeke Could you take a look

Copy link
Contributor

@TiagoDanin TiagoDanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@TiagoDanin TiagoDanin self-requested a review July 8, 2019 18:05
package.json Show resolved Hide resolved
@alexandrtovmach
Copy link
Contributor Author

@TiagoDanin

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative here! This is looking great.

One request: Can you also remove 6.x while you're here? (from package.json, from the tests, and the 6.x files too) -- That version is no longer supported: https://github.com/nodejs/Release#release-schedule

@alexandrtovmach
Copy link
Contributor Author

@zeke Done

Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zeke zeke merged commit 1e6c4ae into nodejs:master Jul 12, 2019
@alexandrtovmach alexandrtovmach deleted the patch/update-content branch March 3, 2020 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants