translate about page in italian #2024
Conversation
Signed-off-by: Aymen Naghmouchi <[email protected]>
ghost
mentioned this pull request
ghost
changed the title
|
What should I do? |
|
Well……Since I notice that you have a conflict translation (both of you have translated the same article), so you have to wait until #1762 is submitted, you can update your codes to the lastest and then continue your changes if possible. |
ghost
mentioned this pull request
|
@aymen94 Hi, we've merged the Italian translation. Please compare the existing version with your changes. |
Signed-off-by: Aymen Naghmouchi <[email protected]>
|
@fhemberger @Maledong i fixed the page |
|
@fhemberger @Maledong |
|
@aymen94 We always let other members of a locale review the translation, please don't merge your own PRs. /cc @nodejs/nodejs-it Please take a look |
There was a problem hiding this comment.
Hi @aymen94,
I had a quick look to your translations.
just some quick hint:
HTTP ha un posto di rilievo in Nodo
it should be "Node" I guess
Solo perché il nodo è progettato senza thread
it should be "Solo perché Node è progettato senza thread"
Le linee guida per la visualizzazione del marchio Node.js sono descritte
nell'[Visual Guidelines]
nell'[Visual Guidelines] should be nelle [Visual Guidelines]
|
@xela92 Thanks for the review, Now I fix. |
Signed-off-by: Aymen Naghmouchi <[email protected]>
|
@lpinca thanks for review/fix. |
|
@fhemberger I think it's time to close the pull request and do the merge. |
|
@aymen94 as far as I can see none of my comments have been addressed. Forgot to push? |
oh yes, now I push. |
|
@lpinca You can do the merge, so I can close PR 😄 |
locale/it/about/index.md
Outdated
| [Event Machine][] o Python's [Twisted][]. Node prende un po' dal modello a eventi. | ||
| Presenta un [event loop][] come un costrutto di runtime invece che come una libreria. In altri sistemi, c'è sempre una chiamata di blocco per avviare l'event-loop. | ||
| Node.js è influenzato da sistemi come la [Event Machine][] di Ruby o [Twisted][] di Python. | ||
| Node.js prende un po' dal modello a eventi. |
There was a problem hiding this comment.
I think it's better to remove this. It seems a little out of context.
There was a problem hiding this comment.
Is write on the English page
There was a problem hiding this comment.
Ok then I'd would prefer to use the original translation "Node.js porta il modello ad eventi un po' oltre." which better reflect the corresponding English sentence "Node takes the event model a bit further" in my opinion.
There was a problem hiding this comment.
Let's keep it open until tomorrow just in case someone wants to chime in. We can then merge it. Thank you for your patience.
|
@fhemberger @lpinca |
ghost
merged commit
|
@aymen94：Thanks for your contribution! |
translated 'about' page in Italian