-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name repl anonymous functions #9356
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name anonymous functions in repl module the changes are related to Ref: #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable
removing long function names to match the 80 character limitation
LGTM if CI is ✅ |
jasnell
approved these changes
Oct 30, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
silverwind
approved these changes
Nov 1, 2016
Thanks! Landed in e658f5b. |
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2016
the changes are related to #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable PR-URL: #9356 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
the changes are related to #8913 regarding the naming of just the inline anonymous functions that are not assigned to a variable PR-URL: #9356 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
added
the
baking-for-lts
PRs that need to wait before landing in a LTS release.
label
May 8, 2017
MylesBorins
added
dont-land-on-v6.x
and removed
baking-for-lts
PRs that need to wait before landing in a LTS release.
lts-watch-v6.x
labels
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
repl
Description of change
repl: name anonymous functions in repl module
name anonymous functions in repl module
the changes are related to Ref: #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable