Skip to content

Commit

Permalink
repl: name anonymous functions
Browse files Browse the repository at this point in the history
the changes are related to #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9356
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
  • Loading branch information
pvsousalima authored and silverwind committed Nov 1, 2016
1 parent d1785d9 commit e658f5b
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ function REPLServer(prompt,

self.eval = self._domain.bind(eval_);

self._domain.on('error', function(e) {
self._domain.on('error', function debugDomainError(e) {
debug('domain error');
const top = replMap.get(self);
internalUtil.decorateErrorStack(e);
Expand Down Expand Up @@ -436,13 +436,13 @@ function REPLServer(prompt,
};
}

self.on('close', function() {
self.on('close', function emitExit() {
self.emit('exit');
});

var sawSIGINT = false;
var sawCtrlD = false;
self.on('SIGINT', function() {
self.on('SIGINT', function onSigInt() {
var empty = self.line.length === 0;
self.clearLine();
self.turnOffEditorMode();
Expand All @@ -465,7 +465,7 @@ function REPLServer(prompt,
self.displayPrompt();
});

self.on('line', function(cmd) {
self.on('line', function onLine(cmd) {
debug('line %j', cmd);
sawSIGINT = false;

Expand Down Expand Up @@ -586,7 +586,7 @@ function REPLServer(prompt,
}
});

self.on('SIGCONT', function() {
self.on('SIGCONT', function onSigCont() {
if (self.editorMode) {
self.outputStream.write(`${self._initialPrompt}.editor\n`);
self.outputStream.write(
Expand Down Expand Up @@ -951,7 +951,7 @@ function complete(line, callback) {
addStandardGlobals(completionGroups, filter);
completionGroupsLoaded();
} else {
this.eval('.scope', this.context, 'repl', function(err, globals) {
this.eval('.scope', this.context, 'repl', function ev(err, globals) {
if (err || !Array.isArray(globals)) {
addStandardGlobals(completionGroups, filter);
} else if (Array.isArray(globals[0])) {
Expand All @@ -968,7 +968,7 @@ function complete(line, callback) {
}
} else {
const evalExpr = `try { ${expr} } catch (e) {}`;
this.eval(evalExpr, this.context, 'repl', function(e, obj) {
this.eval(evalExpr, this.context, 'repl', function doEval(e, obj) {
// if (e) console.log(e);

if (obj != null) {
Expand Down

0 comments on commit e658f5b

Please sign in to comment.