-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: check that process.execPath
is a realpath
#9229
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
42d045e
test: check that `process.execPath` is a realpath
addaleax 4038272
[squash] add comment saying “The console.log() output is part of the …
addaleax c0e5fa6
[squash] reorder asserts to get proper debug output on windows
addaleax de7c161
[squash] skip test on windows
addaleax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const child_process = require('child_process'); | ||
const path = require('path'); | ||
const fs = require('fs'); | ||
|
||
assert.strictEqual(process.execPath, fs.realpathSync(process.execPath)); | ||
|
||
if (common.isWindows) { | ||
common.skip('symlinks are weird on windows'); | ||
return; | ||
} | ||
|
||
if (process.argv[2] === 'child') { | ||
// The console.log() output is part of the test here. | ||
console.log(process.execPath); | ||
} else { | ||
common.refreshTmpDir(); | ||
|
||
const symlinkedNode = path.join(common.tmpDir, 'symlinked-node'); | ||
fs.symlinkSync(process.execPath, symlinkedNode); | ||
|
||
const proc = child_process.spawnSync(symlinkedNode, [__filename, 'child']); | ||
assert.strictEqual(proc.stderr.toString(), ''); | ||
assert.strictEqual(proc.stdout.toString(), `${process.execPath}\n`); | ||
assert.strictEqual(proc.status, 0); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a comment mentioning at the the
console.log()
output here is part of the testThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell done!