test: check that `process.execPath` is a realpath #9229

addaleax · 2016-10-21T21:05:29Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

This test is only here to ensure consistent cross-platform behaviour.

addaleax · 2016-10-21T21:06:31Z

~~CI: https://ci.nodejs.org/job/node-test-commit/5720/~~
~~CI: https://ci.nodejs.org/job/node-test-commit/5721/~~
~~CI: https://ci.nodejs.org/job/node-test-commit/5722/~~
CI: https://ci.nodejs.org/job/node-test-commit/5723/

jasnell · 2016-10-21T21:15:29Z

test/parallel/test-process-execpath.js

+assert.strictEqual(process.execPath, fs.realpathSync(process.execPath));
+
+if (process.argv[2] === 'child') {
+  console.log(process.execPath);


can you please add a comment mentioning at the the console.log() output here is part of the test

@jasnell done!

…test here.”

addaleax · 2016-10-21T21:59:47Z

I’ve set the test to skip on Windows since I don’t know if it even makes sense there… if somebody in @nodejs/platform-windows has an opinion, feel free to voice that :)

Trott · 2016-10-21T22:10:03Z

test/parallel/test-child-process-exec-error.js

+if (common.isWindows) {
+  common.skip('symlinks are weird on windows');
+  return;
+}


Why is the above check done? The test does not use symlinks. (If there is a good reason to skip the test, then the check for common.isWindows below can be removed.)

(Looks like this was meant for test-process-execpath.js and not test-child-process-exec-error.js?)

Trott · 2016-10-21T22:10:54Z

I’ve set the test to skip on Windows since I don’t know if it even makes sense there… if somebody in @nodejs/platform-windows has an opinion, feel free to voice that :)

Is it possible you accidentally added the skip to the wrong file? Looks that way to me...

addaleax · 2016-10-21T22:14:44Z

Is it possible you accidentally added the skip to the wrong file? Looks that way to me...

That is totally possible. Updated! 😄

joaocgreis · 2016-10-25T16:47:39Z

This works on Windows if you use 'symlinked-node.exe'. But the test fails and confirms that execPath is not a realpath.

addaleax · 2016-10-25T16:50:07Z

This works on Windows if you use 'symlinked-node.exe'.

… silly me. Thanks for pointing that out!

But the test fails and confirms that execPath is not a realpath.

Sounds to me like that should be considered a bug, or at least an OS-specific difference that should be documented?

joaocgreis · 2016-10-26T12:12:30Z

Looks like a bug to me, I'll take a look.

@addaleax If you want to land, include the Windows skip and I'll remove it with the fix.

Reviewing, the code looks good, but what's the motivation for this? Consistency sounds good, do we imply this somewhere in the docs or would it be just a nice to have?

addaleax · 2016-10-26T16:17:55Z

If you want to land, include the Windows skip and I'll remove it with the fix.

Sounds good to me

Reviewing, the code looks good, but what's the motivation for this? Consistency sounds good, do we imply this somewhere in the docs or would it be just a nice to have?

It came from discussion around an npm change of mine, npm/npm#14374. We weren’t quite sure whether applying fs.realpathSync to process.execPath makes sense or not, so I got curious and wanted to see whether the behaviour is consistent (and if it is, try to get a test for that in here).

So, yes, it’s just nice to have, not something we guarantee in our docs right now.

addaleax · 2016-11-13T21:52:06Z

Would anybody mind giving this a look? (@joaocgreis … was that an affirmative review?)

bnoordhuis · 2016-11-15T08:45:08Z

New CI, the old one 404s: https://ci.nodejs.org/job/node-test-pull-request/4845/

addaleax · 2016-11-16T00:44:45Z

Landed in 89469c8, thanks for reviewing!

This test is only here to ensure consistent cross-platform behaviour. PR-URL: #9229 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

joaocgreis · 2016-12-06T04:21:28Z

(@addaleax I missed that last mention, sorry 😔)

Found this libuv PR: libuv/libuv#293 . Doesn't look like we have reasons here to push it farther than it went, so no real execPath on Windows for now.

addaleax · 2016-12-06T17:42:59Z

@joaocgreis Thanks for followingup! I kind of wonder if we should just apply Node’s fs.realpath here… but then again maybe it’s best to just leave this alone. ;)

This test is only here to ensure consistent cross-platform behaviour. PR-URL: nodejs#9229 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

This test is only here to ensure consistent cross-platform behaviour. PR-URL: #9229 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

test: check that process.execPath is a realpath

42d045e

This test is only here to ensure consistent cross-platform behaviour.

addaleax added test Issues and PRs related to the tests. process Issues and PRs related to the process subsystem. labels Oct 21, 2016

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 21, 2016

jasnell reviewed Oct 21, 2016

View reviewed changes

addaleax added 2 commits October 21, 2016 23:27

[squash] add comment saying “The console.log() output is part of the …

4038272

…test here.”

[squash] reorder asserts to get proper debug output on windows

c0e5fa6

Trott reviewed Oct 21, 2016

View reviewed changes

[squash] skip test on windows

de7c161

addaleax force-pushed the test-proc-execpath-realpath branch from 854127f to de7c161 Compare October 21, 2016 22:14

bnoordhuis approved these changes Nov 15, 2016

View reviewed changes

evanlucas approved these changes Nov 15, 2016

View reviewed changes

addaleax closed this Nov 16, 2016

addaleax deleted the test-proc-execpath-realpath branch November 16, 2016 00:44

addaleax added the land-on-v6.x label Dec 8, 2016

MylesBorins added the land-on-v4.x label Dec 20, 2016

This was referenced Dec 21, 2016

V6.9.3 proposal #10394

Merged

V4.7.1 proposal #10395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: check that `process.execPath` is a realpath #9229

test: check that `process.execPath` is a realpath #9229

addaleax commented Oct 21, 2016

addaleax commented Oct 21, 2016 •

edited

Loading

jasnell Oct 21, 2016

addaleax Oct 21, 2016

addaleax commented Oct 21, 2016

Trott Oct 21, 2016

Trott Oct 21, 2016

Trott commented Oct 21, 2016

addaleax commented Oct 21, 2016

joaocgreis commented Oct 25, 2016

addaleax commented Oct 25, 2016

joaocgreis commented Oct 26, 2016

addaleax commented Oct 26, 2016

addaleax commented Nov 13, 2016

bnoordhuis commented Nov 15, 2016

addaleax commented Nov 16, 2016 •

edited

Loading

joaocgreis commented Dec 6, 2016

addaleax commented Dec 6, 2016

test: check that process.execPath is a realpath #9229

test: check that process.execPath is a realpath #9229

Conversation

addaleax commented Oct 21, 2016

Checklist

Affected core subsystem(s)

Description of change

addaleax commented Oct 21, 2016 • edited Loading

jasnell Oct 21, 2016

Choose a reason for hiding this comment

addaleax Oct 21, 2016

Choose a reason for hiding this comment

addaleax commented Oct 21, 2016

Trott Oct 21, 2016

Choose a reason for hiding this comment

Trott Oct 21, 2016

Choose a reason for hiding this comment

Trott commented Oct 21, 2016

addaleax commented Oct 21, 2016

joaocgreis commented Oct 25, 2016

addaleax commented Oct 25, 2016

joaocgreis commented Oct 26, 2016

addaleax commented Oct 26, 2016

addaleax commented Nov 13, 2016

bnoordhuis commented Nov 15, 2016

addaleax commented Nov 16, 2016 • edited Loading

joaocgreis commented Dec 6, 2016

addaleax commented Dec 6, 2016

test: check that `process.execPath` is a realpath #9229

test: check that `process.execPath` is a realpath #9229

addaleax commented Oct 21, 2016 •

edited

Loading

addaleax commented Nov 16, 2016 •

edited

Loading