Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-esm-loader-hooks-inspect-brk #56050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 28, 2024

Refs: #54827
Refs: #51560

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 28, 2024
@lpinca
Copy link
Member Author

lpinca commented Nov 28, 2024

This should fix https://ci.nodejs.org/job/node-test-commit-plinux/56544/nodes=rhel8-ppc64le/testReport/junit/(root)/parallel/test_esm_loader_hooks_inspect_brk/

---
duration_ms: 15449.878
exitcode: 1
severity: fail
stack: |-
  [test] Connecting to a child Node process
  [test] Testing /json/list
  [err] Debugger listening on ws://127.0.0.1:39645/fd174c31-85ea-460b-8b5c-aad1caeddb9c
  [err] For help, see: https://nodejs.org/en/docs/inspector
  [err]
  [err] Debugger attached.
  [err]
  Timed out waiting for matching notification (Debugger.paused)
  1
...

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (24a8662) to head (e83cba9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56050      +/-   ##
==========================================
- Coverage   87.97%   87.97%   -0.01%     
==========================================
  Files         656      656              
  Lines      188383   188383              
  Branches    35973    35976       +3     
==========================================
- Hits       165732   165726       -6     
- Misses      15821    15832      +11     
+ Partials     6830     6825       -5     

see 30 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants