Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove async-hooks/test-writewrap flaky designation #56048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 28, 2024

The issue is the same as other tests that time out.

Refs: #54918
Refs: #54802

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (24a8662) to head (6cd4edf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56048      +/-   ##
==========================================
- Coverage   87.97%   87.96%   -0.01%     
==========================================
  Files         656      656              
  Lines      188383   188383              
  Branches    35973    35975       +2     
==========================================
- Hits       165732   165716      -16     
- Misses      15821    15838      +17     
+ Partials     6830     6829       -1     

see 37 files with indirect coverage changes

The issue is the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants