lib: fix fs.readdir recursive async #56041
Open
+126
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56041 +/- ##
==========================================
- Coverage 88.00% 87.95% -0.06%
==========================================
Files 653 656 +3
Lines 188093 188454 +361
Branches 35942 35990 +48
==========================================
+ Hits 165537 165758 +221
- Misses 15734 15860 +126
- Partials 6822 6836 +14
|
github-actions
bot
removed
the
request-ci
anonrig
reviewed
Nov 28, 2024
| } | ||
| } | ||
|
|
||
| function handleDirents({ result, currentPath, context }) { |
There was a problem hiding this comment.
Would you mind adding jsdoc to all newly/updated functions?
There was a problem hiding this comment.
I haven't added jsdoc to these ones because they are not public, they are used inside readdirRecursive (which has JSDoc). It seems a pattern on this file.
jazelly
reviewed
Nov 28, 2024
| @@ -1369,6 +1369,109 @@ function mkdirSync(path, options) { | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| * An recurssive algorithm for reading the entire contents of the `basePath` directory. | |||
There was a problem hiding this comment.
Suggested change
| * An recurssive algorithm for reading the entire contents of the `basePath` directory. | |
| * An recursive algorithm for reading the entire contents of the `basePath` directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56006
cc: @aduh95 @Ethan-Arrowood