test,crypto: make crypto tests work with BoringSSL #55491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Oct 22, 2024
codebytere
force-pushed
the
crypto-flex-bssl
branch
from
4b48915
to
9e75a3f
Compare
RedYetiDev
added
crypto
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55491 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 653 653
Lines 187437 187437
Branches 36074 36078 +4
=======================================
+ Hits 165723 165730 +7
+ Misses 14949 14938 -11
- Partials 6765 6769 +4 |
anonrig
approved these changes
Oct 22, 2024
lpinca
approved these changes
Oct 22, 2024
panva
approved these changes
Oct 23, 2024
panva
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in cbb72eb |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55491 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks crypto tests a bit to make them work for both OpenSSL and BoringSSL. This allows Electron to reduce relevant patch surface area.