test: fix determining lower priority #55908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55908 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 653 653
Lines 187735 187735
Branches 36181 36177 -4
=======================================
+ Hits 166141 166145 +4
+ Misses 14819 14817 -2
+ Partials 6775 6773 -2
|
aduh95
reviewed
Nov 18, 2024
aduh95
approved these changes
Nov 19, 2024
aduh95
added
the
author ready
13 tasks
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f270462 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55908 Fixes: NixOS/nixpkgs#355919 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55908 Fixes: NixOS/nixpkgs#355919 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55908 Fixes: NixOS/nixpkgs#355919 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #55739, making it actually work.
prioritymeansnicenesshere, so the comparison should be other way around. 😅Fixes: NixOS/nixpkgs#355919 (should be applied on top of #55739 until both get into release)
Alternative to: #55863 (/cc @aduh95)