test: ensure that test priority is not higher than current priority #55739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
LiviaMedeiros
added
os
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55739 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187747 187752 +5
Branches 36127 36121 -6
=======================================
+ Hits 165972 165981 +9
+ Misses 15009 15005 -4
Partials 6766 6766 |
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Nov 6, 2024
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Nov 8, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in a094a81 |
|
Someone is reporting seeing |
|
Interesting. I guess it would be reasonable to skip NixOS together with |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55739 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails if parent's (e.g.
sshd) niceness is already lower than10and we're not root.