Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: make sure clear the old timer in http server #52118

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/_http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ function setupConnectionsTracking() {
this[kConnections] = new ConnectionsList();
}

if (this[kConnectionsCheckingInterval]) {
clearInterval(this[kConnectionsCheckingInterval]);
}
// This checker is started without checking whether any headersTimeout or requestTimeout is non zero
// otherwise it would not be started if such timeouts are modified after createServer.
this[kConnectionsCheckingInterval] =
Expand Down
24 changes: 24 additions & 0 deletions test/parallel/test-http-server-clear-timer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';
const common = require('../common');
const http = require('http');
const assert = require('assert');
const { kConnectionsCheckingInterval } = require('_http_server');

let i = 0;
let timer;
const server = http.createServer();
server.on('listening', common.mustCall(() => {
// If there was a timer, it must be destroyed
if (timer) {
assert.ok(timer._destroyed);
}
// Save the last timer
timer = server[kConnectionsCheckingInterval];
if (++i === 2) {
server.close(() => {
assert.ok(timer._destroyed);
});
}
}, 2));
server.emit('listening');
server.emit('listening');
Loading