Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make sure clear the old timer in http server #52118

Merged
merged 1 commit into from
Mar 19, 2024
Merged

lib: make sure clear the old timer in http server #52118

merged 1 commit into from
Mar 19, 2024

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Mar 16, 2024 •
edited
Loading

Currently we can call listen twice with same server in cluster worker and the server will emit listening event twice.
The http server will call setInterval inlistening event handler, but the second call do not clear the old timer which will make the memory leak.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 16, 2024
@theanarkh theanarkh mentioned this pull request Mar 16, 2024
Merged
4 tasks
mcollina
mcollina approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57804/

@theanarkh theanarkh added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4e9ce7c into nodejs:main Mar 19, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4e9ce7c

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@theanarkh @rdw-msft
lib: make sure clear the old timer in http server
07b1b94 
PR-URL: nodejs#52118
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@theanarkh @marco-ippolito
lib: make sure clear the old timer in http server
abca33f 
PR-URL: #52118
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@theanarkh @marco-ippolito
lib: make sure clear the old timer in http server
d33fc36 
PR-URL: #52118
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theanarkh @nodejs-github-bot @mcollina @ShogunPanda