Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove duplicate fork module import #4634

Closed
wants to merge 1 commit into from
Closed

test: remove duplicate fork module import #4634

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 11, 2016

fork is imported twice in a row. Remove duplication.

@Trott
test: remove duplicate fork module import
5451c7c 
`fork` is imported twice in a row. Remove duplication.
@Trott Trott added the test Issues and PRs related to the tests. label Jan 11, 2016
@jbergstroem
Copy link
Member

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 12, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jan 12, 2016

LGTM

2 similar comments
@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2016

LGTM

@targos
Copy link
Member

targos commented Jan 12, 2016

LGTM

targos pushed a commit that referenced this pull request Jan 12, 2016
@Trott @targos
test: remove duplicate fork module import
0f3d75e 
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Jan 12, 2016

landed in 0f3d75e

@targos targos closed this Jan 12, 2016
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
@Trott
test: remove duplicate fork module import
ea6e26d 
`fork` is imported twice in a row. Remove duplication.

PR-URL: #4634
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 12, 2016
Merged
@MylesBorins
Copy link
Contributor

another fix has already landed on LTS making this one moot. Adding to ignore list

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: remove duplicate fork module import
960d6fb 
`fork` is imported twice in a row. Remove duplication.

PR-URL: nodejs#4634
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott Trott deleted the redecl-fork branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jbergstroem @cjihrig @mscdex @targos @MylesBorins @jasnell