V5.4.1 propose #4626
V5.4.1 propose #4626
Conversation
I feel really really silly that I listed that in the last release but didn't actually have it.. Maybe say |
MylesBorins
force-pushed
the
v5.4.1-propose
branch
from
c4c8f0d
to
9f5f328
Compare
|
Also could you fix that url shortening so it is |
MylesBorins
force-pushed
the
v5.4.1-propose
branch
from
9f5f328
to
48ad902
Compare
mscdex
added
the
meta
|
|
Arm-fanned job is running again https://ci.nodejs.org/job/node-test-commit-arm-fanned/1046/ edit: Looks like that failure is consistent. edit: ran on v5.4.0 and also had failure. edit: ran on v5.3.0 and there are no failures |
|
@jbergstroem Any idea what the issue might be with the above CI failure? I want to rule out a problem with CI passing in environment variables or whatever before I look at the code (which I can't do until later anyway...) |
|
Looks like it fails with the code reverted as well but fails differently? Woot, sort of, I guess... |
|
I'm mostly finding it super odd how v5.3 passes, v5.4 / 5.4.1 fails, but master passses WUT |
|
@jbergstroem has attempted to change something in CI. Running again to see if it is fixed --> https://ci.nodejs.org/job/node-test-commit-arm-fanned/1056/ |
|
The above test had an unrelated failure (well unrelated to past failures). Running the full CI one more time because |
|
so, he latest arm fails is because the build volume is mounted in a different folder than the temp directory; i'll look at fixing that locally. so; "expected fail would pass" |
|
..and as for windows, we have a slave connection issue. Current state looks good to me. |
|
One more time: https://ci.nodejs.org/job/node-test-pull-request/1202/ |
|
✅ full green! |
|
@nodejs/build @Fishrock123 did we get ssh keys for the new release team members on to the server in |
|
Running CITGM: https://ci.nodejs.org/job/thealphanerd-smoker/28/ |
|
@nodejs/build Uh oh, I don't think so. I was going to do it alongside adding the keys to the readme, but those were merged so fast I didn't get to look at them and forgot about it... |
|
The test suite for tape is failing on fedora 23. Rerunning for 5.4.0 to see if this is new |
General improvements to crypto.markdown including new and revised examples. PR-URL: #4435 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
PR-URL: #4549 Reviewed-By: Colin Ihrig <[email protected]>
Refs: #3254 PR-URL: #4540 Reviewed-By: James M Snell <[email protected]>
Adds Myles Borins and his public key to the README PR-URL: #4578 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Adds Evan Lucas and his public key to the README for releases PR-URL: #4579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
It avoids the creation of unnecessary handles. This issue is causing intermitent failures in `test-cluster-disconnect-race` on `FreeBSD` and `OS X`. The problem is that the `worker2.disconnect` is being called on the master before the `queryServer` is handled, causing the worker to be deleted, then the Server handle is created afterwards. Later on, when `removeWorker` is called from the `exit` handler, there are no workers left, but one handle, thus the `AssertionError`. Add a new `test/sequential/test-cluster-disconnect-leak` based on `test-cluster-disconnect-race` that creates lots of workers and fails consistently without this patch. PR-URL: #4465 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Rich Trott <[email protected]>
fix description about the latest LTS release download page to make it clear PR-URL: #4583 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few tests in test/gc include the http module twice. Remove duplicate require(). PR-URL: #4606 Reviewed-By: Brian White <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: #3579 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove redeclarations of variables in node.js. This includes removing
one apparently unnecessary `NativeModule.require('module')`.
PR-URL: #4605
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
In lib/_http_client.js, the variable `conn` was declared with the `var` keyword three times in the same scope. This change eliminates the variable entirely. PR-URL: #4612 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>>
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]>
This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: #4648 Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
`fork` is imported twice in a row. Remove duplication. PR-URL: #4634 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
force-pushed
the
v5.4.1-propose
branch
from
48ad902
to
0069a4a
Compare
|
Rebase against v5.x to get backported v8 fix. Added two new commits from master. Backed out commit for arrow functions to see if that was what was breaking fedora 23 on citgm. CI: https://ci.nodejs.org/job/node-test-pull-request/1206/ edit: CI failures on PPC appear to all be timeout related, I'm going to write them off as unrelated |
|
One more CI run before the Build group meeting. will cut release after assuming all green https://ci.nodejs.org/job/node-test-pull-request/1207/ edit: @mhdawson can you look at the PPC failures we are getting here. What is causing these timeouts? |
MylesBorins
force-pushed
the
v5.4.1-propose
branch
from
0069a4a
to
e7d1c69
Compare
|
Running release job: https://ci.nodejs.org/job/iojs+release/339/ |
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) #3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: #4626 Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
@thealphanerd which key was used to sign this release? The new key from #4657? |
|
@Starefossen this one was signed by @Fishrock123 on behalf of @thealphanerd, so you can go ahead without any change for Docker for now and it should be fine. |
PR-URL: nodejs#86 Related: nodejs/node#4626 Signed-off-by: Hans Kristian Flaatten <[email protected]>
PR-URL: docker-library#1336 Related: nodejs/node#4626 Related: nodejs/docker-node#86 Signed-off-by: Hans Kristian Flaatten <[email protected]>
PR-URL: docker-library#1337 Related: nodejs/node#4626 Related: nodejs/docker-node#86 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) nodejs#3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: nodejs#4626 Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: docker-library#1337 Related: nodejs/node#4626 Related: nodejs/docker-node#86 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Notable Changes
Known issues
dns.setServers()while a DNS query is in progress can cause the process to crash on a failed assertion. #894url.resolvemay transfer the auth portion of the url when resolving between two full hosts, see #1435.commits
ff539c5bb5] - cluster: ignore queryServer msgs on disconnection (Santiago Gimeno) #446500148b3de1] - deps: backport 066747e from upstream V8 (Ali Ijaz Sheikh) #46253912b5cbda] - doc: adds usage of readline line-by-line parsing (Robert Jefe Lindstaedt) #4609102fb7d3a1] - doc: remove "above" and "below" references (Richard Sun) #4499df87176ae0] - doc: update stylesheet to match frontpage (Roman Reiss) #4621ede98d1f98] - doc: stronger suggestion for userland assert (Wyatt Preul) #4535fdfc72c977] - doc: label http.IncomingMessage as a Class (Sequoia McDowell) #4589b181e26975] - doc: document http's server.listen return value (Sequoia McDowell) #459097aaeb8519] - doc: fix description about the latest-codename (Minwoo Jung) #45830126615d1e] - doc: add Evan Lucas to Release Team (Evan Lucas) #4579ec73c69412] - doc: add Myles Borins to Release Team (Myles Borins) #4578e703c9a4e2] - doc: bring releases.md up to date (cjihrig) #4540ac1108d5e7] - doc: add missing backtick for readline (Brian White) #454909bc0c6a05] - doc: improvements to crypto.markdown copy (James M Snell) #4435787c5d96bd] - http: remove variable redeclaration (Rich Trott) #4612145b66820f] - module: move unnecessary work for early return (Andres Suarez) #3579ffb7deb443] - net: remove hot path comment from connect (Evan Lucas) #4648799aa74d90] - net: fix dns lookup for android (Josh Dague) #45809accebe087] - net, doc: fix line wrapping lint in net.js (James M Snell) #458837a546b490] - src: remove redeclarations of variables (Rich Trott) #4605b515ccc2a1] - stream: remove useless if test in transform (zoubin) #4617ea6e26d904] - test: remove duplicate fork module import (Rich Trott) #4634b14b2aec5e] - test: require common module only once (Rich Trott) #4611f28a640505] - test: only include http module once (Rich Trott) #46066f9a96f497] - test: fix flaky unrefed timers test (Rich Trott) #4599b70eec8f7b] - tls_legacy: do not read on OpenSSL's stack (Fedor Indutny) #4624